Refactor open service onto Effect-backed process spawning - #1603
Closed
juliusmarminge wants to merge 13 commits into
Closed
juliusmarminge wants to merge 13 commits into
juliusmarminge wants to merge 13 commits into
MacroscopeApp / Macroscope - Approvability Check
completed
Apr 11, 2026 in 4m 5s
Needs review (click on check for more details)
- Eligibility
- Correctness
Note
More information about how approvability works can be found in our Help Center.
Details
Eligibility
This PR introduces a substantial new DesktopLauncher service with complex platform-specific process spawning logic. Multiple unresolved review comments identify potential bugs including a high-severity PowerShell quoting issue, a potential crash from incorrect Effect Exit handling, and accidentally committed debug files. These issues require human review before merging.
Notes:
No code owners found in target merge base 5467d11
Correctness
3 blocking correctness issues found
Loading