Repository navigation
fix(web): truncate thread titles before the workspace toggle - #15371
NikitaMGrimm wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused header-layout fix that replaces a fixed padding value with the existing titlebar geometry so long thread titles stop before the workspace toggle. It adds no new capability, schema, deployment behavior, or static-analysis override, and leaves the closed-panel path unchanged. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe chat header now uses a CSS variable for right padding when the right panel is open. The variable combines the workspace controls inset and titlebar control size. When the panel is closed, the existing padding remains unchanged. ChangesChat header inset
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The open-panel title inset accounts for the workspace controls, while closed-panel spacing remains unchanged. The change is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Dismissing prior approval to re-evaluate 0a9d409
|
Note Grok responding on behalf of Julius. Thanks for this! The same Windows desktop overlap between the thread title and the workspace toggle was fixed by #16869, which just merged and moves the toggle to the chat header's edge instead of reserving extra title padding. Closing this one as superseded, but if you still see the title running under the toggle on current main, let us know. |
When a Windows desktop window has the right panel open, a long thread title can run underneath the Workspace toggle as the chat pane shrinks. The toggle keeps the native titlebar-controls inset, but the breadcrumb reserves a fixed 40px.
Reserve the existing controls-right inset plus the existing toggle width, so the title's existing ellipsis stops before the icon. Normal browser spacing remains 40px. The icon position and Workspace inline/popover behavior are unchanged. This qualifies as the small, obvious bug-fix exception: it corrects overlapping header content without adding a feature or changing product defaults.
Evidence
One side-by-side resize video: BEFORE left / AFTER right, with mouse-drag indicators
Reproduced on upstream
00eb8f6183through T3's collaborative Browser at 1280x800, using isolated worktree data and a long thread title. The Browser simulates the Windows WCO controls-right inset at 156px; this is not a rebuilt native Electron recording. With the right panel initially 540px wide, the baseline title extends to x=608 while the icon starts at x=556. Resizing toward the 384px chat minimum keeps the overlap reproducible.After the fix, the title ends 38px before the icon at chat widths of 739px, 479px, and 384px. The same resize sequence now truncates the title while preserving the toggle position. The full title remains in its accessible label. Clicking the Workspace toggle still opens its popover. A normal 12px browser inset keeps 40px of reserved space; closing the right panel retains the existing 96px padding.
Validation
vp test run apps/web/src/components/chat/ChatHeader.test.ts: 3 tests passed.vp lint apps/web/src/components/chat/ChatHeader.tsx apps/web/src/index.css: no errors; one pre-existing effect-dependency warning at ChatHeader.tsx:154.vp run --filter @t3tools/web typecheck, andgit diff --checkpassed.test-t3-app; final video fully decode-checked.This changes the shared web/Electron header only. React Native has a separate header; providers, wire contracts, connection modes, and documentation are unaffected. Native Electron was not rebuilt.
Model: GPT-6.1-Sol. Harness: Codex through T3 Code.