Skip to content

fix(server): restarts keep delegated tasks, queued threads, and stops intact #15323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 11 commits into from
Oct 3, 2026
Merged

fix(server): restarts keep delegated tasks, queued threads, and stops intact #15323

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b055dad
fix(server): restarts keep delegated tasks, queued threads, and stops…
maria-rcks Oct 3, 2026
db1a97c
perf(server): select unheld queued runs in their own recovery arm
maria-rcks Oct 3, 2026
4f7f58c
fix(server): a restart doesn't settle a delegated child that was wait…
maria-rcks Oct 3, 2026
d307ede
fix(server): hold delegated results through repeated restarts and fai…
maria-rcks Oct 3, 2026
a244b88
fix(server): keep restart state when providers stop with the server
maria-rcks Oct 3, 2026
c5c985e
fix(server): recovery reads unfinished runs as the latest, matching r…
maria-rcks Oct 3, 2026
c61148b
fix(server): preserve restart delivery and completion ordering
maria-rcks Oct 3, 2026
bfde2ab
fix(server): retain restart notes until provider completion
maria-rcks Oct 3, 2026
37f5e91
test(server): associate recovery rosters with their provider runs
maria-rcks Oct 3, 2026
b8c3d46
perf(server): select background recovery owners once per provider
maria-rcks Oct 3, 2026
ad0bf37
fix(server): retain restart note delivery across steered attempts
maria-rcks Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
473 changes: 473 additions & 0 deletions apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

262 changes: 167 additions & 95 deletions apps/server/src/orchestration-v2/Orchestrator.ts
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 10 additions & 3 deletions apps/server/src/orchestration-v2/ProjectionStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,10 @@ function needsRecovery(
}
case "runtime":
return (
projection.runs.some((run) =>
["queued", "preparing", "starting", "running", "waiting"].includes(run.status),
projection.runs.some(
(run) =>
["preparing", "starting", "running", "waiting"].includes(run.status) ||
(run.status === "queued" && run.queueHeld !== true),
) ||
projection.runtimeRequests.some((request) => request.status === "pending") ||
projection.providerSessions.some(
Expand Down Expand Up @@ -3427,7 +3429,12 @@ export const layer: Layer.Layer<ProjectionStoreV2, never, SqlClient.SqlClient> =
ELSE 0 END
)
SELECT thread_id FROM orchestration_v2_projection_runs
WHERE status IN ('queued', 'preparing', 'starting', 'running', 'waiting')
WHERE status IN ('preparing', 'starting', 'running', 'waiting')
UNION
-- A held queue already went through recovery; rereading it on
-- every boot costs a projection read per held thread.
SELECT thread_id FROM orchestration_v2_projection_runs
WHERE status = 'queued' AND json_extract(payload_json, '$.queueHeld') IS NOT 1
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
Outdated
UNION
SELECT thread_id FROM orchestration_v2_projection_runtime_requests
WHERE status = 'pending'
Expand Down
Loading
Loading