Skip to content

fix(web): diff panel opens on all branch changes, not just uncommitted - #15005

Merged
t3dotgg merged 4 commits into
mainfrom
t3code/implement-postplan-design
Oct 3, 2026
Merged

t3dotgg merged 4 commits into
mainfrom
t3code/implement-postplan-design

fix(server): explicit status refresh reads Changes totals after the f…

66c65ec
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Oct 3, 2026 in 1m 32s

No issues identified (2 code objects reviewed).

• Reviewed files modified since 1c7a931; other PR files not modified since then were skipped.
• Merge Base: 4f7760e
• Head: 66c65ec

Details

✅ File Path U3 Bytes Comments Posted Reason
✅ apps/server/src/vcs/VcsStatusBroadcaster.ts 1869 0
➖ apps/server/src/vcs/VcsStatusBroadcaster.test.ts 5258 Excluded by macroscope ignore file
➖ apps/server/src/vcs/GitVcsDriverCore.test.ts 1455 Excluded by macroscope ignore file
✅ apps/server/src/vcs/GitVcsDriverCore.ts 5525 0

Billed Total: 10.00KB of diff | $0.40 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/server/src/vcs/VcsStatusBroadcaster.ts
  • line 474: refreshRemoteStatus only invalidates/reloads local branchChanges when the three commit-count fields differ. A fetch can advance the default/base ref while aheadCount, behindCount, and aheadOfDefaultCount remain identical (for example, both the base and feature branch advance by one commit). readBranchChangeTotals diffs from the newly computed merge base, so its insertions/deletions can change in that case, but the cached local status is retained and the Changes row remains stale until some unrelated local refresh. [ Out of scope (triage) ]