Skip to content

Fix sidebar thread panel weird states. #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Mar 28, 2026
Merged

Fix sidebar thread panel weird states. #1497

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d8fe15
Fix sidebar thread panel collapsed state
shivamhwp Mar 28, 2026
9f19848
Fix sidebar thread toggle rendering
shivamhwp Mar 28, 2026
a791992
Merge branch 'main' into sidebar-ui-weird-state-bug
shivamhwp Mar 28, 2026
4204457
Merge branch 'main' into sidebar-ui-weird-state-bug
juliusmarminge Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions apps/web/src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ import {
} from "./desktopUpdate.logic";
import { Alert, AlertAction, AlertDescription, AlertTitle } from "./ui/alert";
import { Button } from "./ui/button";
import { Collapsible, CollapsibleContent } from "./ui/collapsible";
import { Menu, MenuGroup, MenuPopup, MenuRadioGroup, MenuRadioItem, MenuTrigger } from "./ui/menu";
import { Tooltip, TooltipPopup, TooltipTrigger } from "./ui/tooltip";
import {
Expand Down Expand Up @@ -1220,7 +1219,7 @@ export default function Sidebar() {
};

return (
<Collapsible className="group/collapsible" open={shouldShowThreadPanel}>
<>
<div className="group/project-header relative">
<SidebarMenuButton
ref={isManualProjectSorting ? dragHandleProps?.setActivatorNodeRef : undefined}
Expand Down Expand Up @@ -1301,14 +1300,16 @@ export default function Sidebar() {
</Tooltip>
</div>

<CollapsibleContent>
<SidebarMenuSub
ref={attachThreadListAutoAnimateRef}
className="mx-1 my-0 w-full translate-x-0 gap-0.5 px-1.5 py-0"
>
{renderedThreads.map((thread) => renderThreadRow(thread))}
<SidebarMenuSub
ref={attachThreadListAutoAnimateRef}
className="mx-1 my-0 w-full translate-x-0 gap-0.5 overflow-hidden px-1.5 py-0"
>
{shouldShowThreadPanel && renderedThreads.map((thread) => renderThreadRow(thread))}

{project.expanded && hasHiddenThreads && !isThreadListExpanded && (
{shouldShowThreadPanel &&
project.expanded &&
hasHiddenThreads &&
!isThreadListExpanded && (
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
<SidebarMenuSubItem className="w-full">
<SidebarMenuSubButton
render={<button type="button" />}
Expand All @@ -1323,7 +1324,10 @@ export default function Sidebar() {
</SidebarMenuSubButton>
</SidebarMenuSubItem>
)}
{project.expanded && hasHiddenThreads && isThreadListExpanded && (
{shouldShowThreadPanel &&
project.expanded &&
hasHiddenThreads &&
isThreadListExpanded && (
<SidebarMenuSubItem className="w-full">
<SidebarMenuSubButton
render={<button type="button" />}
Expand All @@ -1338,9 +1342,8 @@ export default function Sidebar() {
</SidebarMenuSubButton>
</SidebarMenuSubItem>
)}
</SidebarMenuSub>
</CollapsibleContent>
</Collapsible>
</SidebarMenuSub>
</>
);
}

Expand Down