Skip to content

Scope git checkout effects and update Effect/Node dependency set - #148

Merged
juliusmarminge merged 2 commits into
mainfrom
feature/add-vscode-open-in-support
Mar 3, 2026
Merged

juliusmarminge merged 2 commits into
mainfrom
feature/add-vscode-open-in-support

fmt

8105951
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check completed Mar 3, 2026 in 11m 35s

1 issue identified (6 code objects reviewed).

• Merge Base: 5e78386
• Head: 8105951

Details

✅ File Path Comments Posted
➖ package.json
➖ apps/server/package.json
➖ apps/desktop/package.json
✅ apps/server/src/wsServer.ts 0
❌ apps/server/src/provider/Layers/CodexAdapter.ts 1
✅ apps/server/src/git/Services/GitCore.ts 0
✅ apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts 0
✅ apps/server/src/git/Layers/GitCore.ts 0
➖ bun.lock

Filtered Issues Details

apps/server/src/git/Layers/GitCore.ts
  • line 1164: The checkoutBranch method spawns a background task refreshCheckedOutBranchUpstream using Effect.forkScoped. This attaches the background fiber's lifecycle to the Scope provided by the caller. When checkoutBranch returns, if the caller-provided Scope is closed (which is the standard behavior when using Effect.scoped to execute an operation), the background fiber will be immediately interrupted before it can complete. This causes the upstream reference refresh to silently fail, leaving the repository state potentially stale, defeating the stated purpose of keeping the checkout responsive. [ Out of scope ]