Skip to content

fix(web): group composer undo the way the Lexical composer did - #14674

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
chrisdeeming:fix/composer-undo-grouping
Oct 2, 2026
Merged

juliusmarminge merged 2 commits into
pingdotgg:mainfrom
chrisdeeming:fix/composer-undo-grouping

fix(web): give a composer cut its own undo step

880acdc
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Oct 2, 2026 in 43s

All clear

All clear

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 1 changed files (no prior completed review)


🔍 Agent activity — 6 tool calls

💭 Assessing TypeScript scope I need to determine if I've changed the scope correctly for the TypeScript files only in grouping.ts, excluding any .tsx files. So, I'll use a pattern like glob apps/**/*.ts to focus on .ts files, while excluding tests. This grouping is just pure helper stuff and shouldn't affect service or server behavior. Overall, it looks like there are no findings to report, and everything seems clear for the final structure mandated.

1. browse_code — apps/web/src/composer-undo-grouping.ts

2. browse_code — Check whether apps/web/src/composer-undo-grouping.ts introduces or consumes an Effect service or server behavior, and whether any other changed in-scope .ts production files exist in PR #14674 (merge base a3abb52 head 880acdc). Brief answer.

3. modify_pr — not performed: the agent's request was refused before it ran

4. browse_code — No need to verify diff: given supplied diff only changed production .ts is apps/web/src/composer-undo-grouping.ts (test excluded, tsx outside include). Is there any Effect service convention violation in that file? Answer briefly.

5. browse_code — Confirm concise conclusion only.

6. browse_code — No further investigation necessary.


Agent Credits: 10 credits

Token usage: 36 uncached input · 113,155 cache-read input · 21,975 cache-write input · 1,092 output
Agent Credits may also include non-token charges from external tools such as web research.