Repository navigation
fix(server): Claude /compact no longer ends early and leaves the thread busy - #14497
Effect Service Conventions: All clear
All clear
Details
Warning
- Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 1 changed files (no prior completed review)
🔍 Agent activity — 12 tool calls
💭 Assessing production lines I'm looking at the changed production lines and considering logging annotations. I want to ensure that everything is safe and that there's a clear origin for the data, maybe involving SDKs or other bounded unions. It seems there are no obvious violations, but there's a test that exists and has been excluded, which might be relevant in a contextual way. I think I need to inspect the placement to make sure everything aligns correctly.
1. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
2. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
3. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
4. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
5. browse_code — In apps/server/src/provider/Layers/ClaudeAdapter.ts inspect only PR additions isResultForOtherTurn and handleResultMessage early return for Effect service conventions violations (service deps, error/log safety, focused test). Is origin.kind a fixed union or arbitrary string? concise.
6. browse_code — The PR adds a focused test at ClaudeAdapter.test.ts lines 1560-1626 that emits unrelated result then matching compact result and asserts completion ordering. Given that test, any definite Effect service conventions finding in changed production lines?
7. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.test.ts
8. browse_code — Confirm whether new log annotation origin: message.origin?.kind is statically bounded SDK union or potentially arbitrary external string; only report if clear concrete violation.
9. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
10. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
11. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.test.ts
12. browse_code — apps/server/src/provider/Layers/ClaudeAdapter.ts
Agent Credits: 38 credits
Token usage: 69 uncached input · 663,549 cache-read input · 80,724 cache-write input · 2,229 output
Agent Credits may also include non-token charges from external tools such as web research.