[kiiwee]

Concurrent MCP-over-ACP connects can each observe an available slot before allocating their connection IDs, allowing the bridge to exceed its existing 16-connection cap.

Allocate the ID and mutex before checking capacity, then check and insert without yielding. This preserves the limit without reserving slots for interrupted allocations.

Validation: focused AcpMcpOverAcpBridge.test.ts suite (5 passing tests), changed-file lint/typecheck, formatting, and diff check. Deterministic regressions cover 17 overlapping connects, freeing and reusing a slot, and interrupted allocation. Scoped checks retain one pre-existing require-yield warning on the unchanged bridge factory.

Targets the Orchestrator V2 branch, not main.

Implementation: Grok 4.6 Build via Grok CLI, with Codex-supervised fixture refinement and scoped verification. Independent review: Claude Opus 5.5 (high) via Claude Code (claude -c). Publication ops: GPT-6.1 Sol (xhigh) via Codex.

[macroscopeapp]

Approvability

Verdict: Approved at c558f44

Macroscope's review found this PR approvable — An existing 16-connection guard is made atomic across concurrent ACP connects, with regression coverage for overlap, interruption, and slot reuse. The production change is confined to bridge bookkeeping and introduces no schema, default, deployment, or static-analysis configuration changes.

Notes:

• Diff unchanged. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 8385071

Dismissing prior approval to re-evaluate 8385071

[macroscopeapp]

Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting).

This review would cost an estimated $15.63, which exceeds your per-review limit of $15.00.

The top 3 files driving up this estimate:

File	Diff Size	Estimate
packages/contracts/src/orchestrationV2.ts	127.11KB	$2.13
apps/server/src/mcp/OrchestratorMcpService.ts	75.70KB	$1.27
apps/server/src/orchestration-v2/EventSink.ts	33.91KB	$0.57

Tip

To get this pull request reviewed, you can:

1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
2. Exclude the file(s) above from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
3. Raise your cost limit in your workspace billing settings.

^{Turn off this reminder going forward}

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 82bbd9b7-0259-408d-8371-cf500992659f

📥 Commits

Reviewing files that changed from the base of the PR and between cc1e634 and c558f44.

📒 Files selected for processing (2)

• apps/server/src/mcp/AcpMcpOverAcpBridge.test.ts
• apps/server/src/mcp/AcpMcpOverAcpBridge.ts

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by claude-opus-5-5 on behalf of Maria

Hi! We are cleaning up open PRs, and this one appears to have been created with an older model (grok 4.6). If this change is really important, we recommend rebuilding the PR with a newer model if possible.