Skip to content

fix(server): report delegated tasks stopped by a server restart - #13345

Closed
saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/v2-subagent-recovery-reports
Closed

saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/v2-subagent-recovery-reports

fix(server): report delegated tasks stopped by a server restart

79554de
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Oct 2, 2026 in 3m 22s

No issues identified (2 code objects reviewed).

• Merge Base: cc1e634
• Head: 79554de

Details

✅ File Path U3 Bytes Comments Posted Reason
✅ apps/server/src/serverRuntimeStartup.ts 981
➖ apps/server/src/relay/AgentAwarenessRelay.test.ts 371 Excluded by macroscope ignore file
✅ apps/server/src/orchestration-v2/EffectWorker.ts 1187 0
➖ apps/server/src/orchestration-v2/RestartContinuation.test.ts 3647 Excluded by macroscope ignore file
✅ apps/server/src/orchestration-v2/ThreadManagementService.ts 1027
➖ apps/server/src/orchestration-v2/ProviderRuntimeRecoveryService.test.ts 984 Excluded by macroscope ignore file
✅ apps/server/src/orchestration-v2/ProviderRuntimeRecoveryService.ts 1762
➖ apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts 13709 Excluded by macroscope ignore file
✅ apps/server/src/orchestration-v2/RestartContinuation.ts 2455
✅ apps/server/src/orchestration-v2/Orchestrator.ts 10329 0

Billed Total: 10.00KB of diff | $0.40 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/server/src/orchestration-v2/EffectWorker.ts
  • line 118: Effect.tapCause also runs for an interrupted continuation, but this handler treats every non-retry failure as terminal. If the daemon is stopped while a continuation on its final allowed attempt is in progress, willRetry is false and it publishes the child’s cancelled result. Process-loss recovery subsequently requeues provider-runtime.continue (it is replay-safe), so the child can resume after its parent has already been told it was cancelled, producing an incorrect terminal result/wake. [ Already posted ]