feat(observability): honor an OpenTelemetry kill switch in the environment by yordis · Pull Request #12925 · pingdotgg/t3code

No issues identified (2 code objects reviewed).

• Reviewed files modified since 0cb6a0d; other PR files not modified since then were skipped.
• Merge Base: 1de563c
• Head: ab2824a

✅	File Path	U3 Bytes	Comments Posted	Reason
✅	`packages/shared/src/otelEnvironment.ts`	8393	0
✅	`apps/desktop/src/backend/DesktopBackendConfiguration.ts`	530	0
➖	`apps/desktop/src/backend/DesktopBackendConfiguration.test.ts`	2322		Excluded by macroscope ignore file

Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

packages/shared/src/otelEnvironment.ts

line 53: blankAsUnset trims the value before it reaches the OpenTelemetry boolean parser, so OTEL_SDK_DISABLED=" true " disables telemetry. The OpenTelemetry environment-variable specification defines only a case-insensitive exact true string as true; any other nonempty value must be false (and should warn). Thus a whitespace-padded value, which another conforming SDK leaves enabled, silently disables T3 Code's exports. Compare the raw value for the standard variable (only exact empty should be treated as unset) rather than trimming it. [ Already posted ]