Skip to content

Add AI-generated worktree branch naming with safe Git branch rename flow - #129

Merged
juliusmarminge merged 22 commits into
mainfrom
codething/34345440
Mar 2, 2026
Merged

Add AI-generated worktree branch naming with safe Git branch rename flow#129
juliusmarminge merged 22 commits into
mainfrom
codething/34345440

Remove unused attachment route path helpers

150e171
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Mar 2, 2026 in 5m 28s

No issues identified (61 code objects reviewed).

• Merge Base: 206eb6a
• Head: 150e171

Details

✅ File Path Comments Posted
➖ apps/web/src/store.ts
➖ apps/web/src/components/ChatView.tsx
✅ apps/server/src/attachmentPaths.ts 0
✅ apps/server/src/attachmentStore.ts 0
✅ apps/server/src/codexAppServerManager.ts 0
✅ apps/server/src/config.ts 0
✅ apps/server/src/git/Layers/CodexTextGeneration.ts 0
✅ apps/server/src/git/Layers/GitCore.ts 0
✅ apps/server/src/git/Services/GitCore.ts 0
✅ apps/server/src/git/Services/TextGeneration.ts 0
✅ apps/server/src/imageMime.ts 0
✅ apps/server/src/orchestration/Layers/ProjectionPipeline.ts 0
✅ apps/server/src/orchestration/Layers/ProviderCommandReactor.ts 0
✅ apps/server/src/provider/Layers/CodexAdapter.ts 0
✅ apps/server/src/serverLayers.ts 0
✅ apps/server/src/wsServer.ts 0
✅ packages/contracts/src/orchestration.ts 0
➖ apps/server/src/imageMime.test.ts
➖ apps/server/src/attachmentStore.test.ts
➖ apps/server/src/projectFaviconRoute.ts
➖ apps/server/src/main.test.ts
➖ apps/server/src/wsServer.test.ts
➖ apps/server/src/git/Layers/GitCore.test.ts
➖ apps/server/src/git/Layers/GitManager.test.ts
➖ apps/server/src/codexAppServerManager.test.ts
➖ apps/server/src/orchestration/Layers/CheckpointReactor.test.ts
➖ apps/web/src/worktreeCleanup.test.ts
➖ apps/server/src/orchestration/Layers/OrchestrationEngine.test.ts
➖ apps/server/src/persistence/Layers/ProjectionThreadMessages.test.ts
➖ apps/server/integration/OrchestrationEngineHarness.integration.ts
➖ apps/server/src/git/Layers/CodexTextGeneration.test.ts
➖ apps/server/src/provider/Layers/CodexAdapter.test.ts
➖ apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts
➖ apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts
➖ apps/server/src/orchestration/Layers/ProjectionPipeline.test.ts

Filtered Issues Details

apps/server/src/git/Layers/CodexTextGeneration.ts
  • line 209: The runCodexJson function creates temporary files sequentially (schemaPath then outputPath) before establishing the cleanup logic. If the second writeTempFile operation (for outputPath) fails—for example, due to a disk full error or permission issue—the generator terminates immediately. Since the cleanup effect (which deletes the files) is only attached via Effect.ensuring to the subsequent inner effect block, the already-created schemaPath file is never deleted, leading to a resource leak on the filesystem. [ Out of scope ]
apps/server/src/wsServer.ts
  • line 251: The normalizeDispatchCommand function introduces a resource leak when processing multiple attachments. The function iterates over the attachments array using Effect.forEach with concurrency: 1, writing each attachment to disk immediately. If a subsequent attachment in the list fails validation (e.g. invalid mime type, empty body, or too large), the loop terminates with an error. However, the files successfully written for previous attachments in the same command are not deleted. Since the command is rejected and never dispatched to the orchestration engine, these files become permanently orphaned in the attachments directory, leading to unbounded disk usage if a client repeatedly sends commands with mixed valid/invalid attachments. [ Already posted ]
View more details on MacroscopeApp