Skip to content

fix(server): restore secrets when settings persistence fails - #12487

Merged
juliusmarminge merged 3 commits into
mainfrom
fix/settings-secret-rollback
Sep 18, 2026
Merged

juliusmarminge merged 3 commits into
mainfrom
fix/settings-secret-rollback

fix(server): roll back partially committed secret writes

a5b1d21
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Sep 18, 2026 in 3m 51s

Not approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This bug fix changes the production transaction for storing, materializing, and rolling back provider and usage-limit secrets, including failure handling for partially committed writes. The added tests are focused, but the sensitive-data scope and substantial runtime persistence changes warrant human review.

Notes:
No code owners found in target merge base ccad9f6