revert(web): remove the compact sidebar - #11685
Conversation
Reverts the compact sidebar rail and compact thread rows (pingdotgg#11525, pingdotgg#9417, pingdotgg#11644, pingdotgg#11652). The feature added a collapsed icon rail and a denser thread list behind an Appearance > Sidebar setting; we are dropping it. The persisted `compactSidebarEnabled` and `sidebarCompactThreadRows` client settings keys go away with it. Client settings decode drops unknown keys, so anyone who had either flag turned on falls back to the default sidebar with no error, same as the retired sidebar v2 beta keys. A collapsed sidebar returns to the pre-existing offcanvas behavior and is still reopened from the titlebar trigger. Keeps pingdotgg#11595 (sparse shelves stay at the bottom), which was written on top of the rail: its `compact` branches collapse to the expanded case.
dd634e4 to
4c1bcec
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This removes a user-facing compact-sidebar mode across the production sidebar, settings UI, persisted client-settings schema, drag-and-drop behavior, and titlebar layout. It also changes the resulting experience for existing opted-in users, making the broad runtime and product-default impact appropriate for human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (22)
💤 Files with no reviewable changes (10)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe PR removes compact sidebar settings and rendering paths. It standardizes sidebar layouts, sorting, controls, and labels, removes related settings UI and APIs, updates schemas, and simplifies relative-time formatting. ChangesCompact sidebar removal
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The compact-sidebar removal preserves the offcanvas fallback and ignores retired settings keys without an identified regression. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
## What's Changed * fix(web): disconnect offline servers from threads by @t3dotgg in pingdotgg/t3code#11671 * feat(web): flatten the connections page into one environments list by @t3dotgg in pingdotgg/t3code#11672 * fix(mobile): keep usage widget rows consistently sized by @juliusmarminge in pingdotgg/t3code#11669 * feat(server): add reusable auth token for dev worktrees by @t3dotgg in pingdotgg/t3code#8606 * feat(settings): choose how responses stream, with a warning on legacy token mode by @t3dotgg in pingdotgg/t3code#11678 * revert(web): remove the compact sidebar by @maria-rcks in pingdotgg/t3code#11685 * build(desktop): bundle the main process and stage only its native externals by @juliusmarminge in pingdotgg/t3code#11410 * build(server): make the CLI bundle loadable as a Node single-executable by @juliusmarminge in pingdotgg/t3code#11316 * ci(release): build, sign, and publish self-contained CLI archives by @juliusmarminge in pingdotgg/t3code#11317 * feat(server): install preview runtimes from release archives by @juliusmarminge in pingdotgg/t3code#11318 * feat(ssh): run preview builds on remotes from the release archive by @juliusmarminge in pingdotgg/t3code#11319 * feat(cli): add t3 update for self-contained installs by @juliusmarminge in pingdotgg/t3code#11451 * feat(server): manage runtimes as release archives only, never from npm by @juliusmarminge in pingdotgg/t3code#11510 * feat(desktop): run the WSL backend from the Linux CLI archive by @juliusmarminge in pingdotgg/t3code#11511 * ci(release): build CLI archives for five targets, each on its own architecture by @juliusmarminge in pingdotgg/t3code#11605 * ci(release): build the JS bundle once and run every platform and architecture in parallel by @juliusmarminge in pingdotgg/t3code#11606 * feat(release): publish npx t3 as a launcher over per-platform executable packages by @juliusmarminge in pingdotgg/t3code#11607 * feat(cli): add t3 uninstall for self-contained installs by @juliusmarminge in pingdotgg/t3code#11659 * feat(web): show each worktree setup step and let users cancel it by @t3dotgg in pingdotgg/t3code#11372 * fix(server): skip device hosts that resolve to the local machine by @juliusmarminge in pingdotgg/t3code#11698 * fix(web): test device hosts across selected environments by @juliusmarminge in pingdotgg/t3code#11699 * feat(desktop): allow disabling the local environment by @juliusmarminge in pingdotgg/t3code#9194 * feat(cli): add t3 service restart and make t3 update repoint the service eagerly by @juliusmarminge in pingdotgg/t3code#11702 * docs(claude): clarify OpenRouter model selection by @shivamhwp in pingdotgg/t3code#11369 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260914.1687...v0.0.41-nightly.20260914.1700 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260914.1700
Removes the compact sidebar: the collapsed icon rail and the dense thread rows, plus the Appearance → Sidebar setting that drove them. Reverts #11525, #9417, #11644 and #11652.
compactSidebarEnabledandsidebarCompactThreadRowsare dropped fromClientSettings. Decoding already ignores unknown keys, so anyone who had either flag on lands on the default sidebar with no error — the same path the retired sidebar v2 beta keys took.packages/contracts/src/settings.test.tsnow asserts that. A sidebar left collapsed goes back to the pre-existing offcanvas behaviour and still reopens from the titlebar trigger.#11595 (sparse shelves stay pinned to the bottom) was written on top of the rail, so it is kept with its
compactbranches collapsed to the expanded case.Evidence
Settings → Appearance, same scroll position and data. The Sidebar section is gone:
Existing users: set Compact sidebar to "Both", confirmed
compactSidebarEnabled: trueandsidebarCompactThreadRows: truewere written tot3code:client-settings:v1, then loaded the reverted build without clearing storage.Checks
vp run --filter @t3tools/web --filter @t3tools/contracts --filter @t3tools/desktop typecheckclean,vp linton the 19 changed files 0 errors, and 218 tests pass acrosssettings.test.ts,timestampFormat.test.ts,DesktopClientSettings.test.ts,ui/sidebar.test.tsxandSidebar.drag.test.ts.Mobile has no compact sidebar surface, so nothing to change there.
Written by
claude-opus-5[1m]on behalf of MariaSummary by CodeRabbit