fix(web): separate expanded tool output from adjacent hover highlights - #11658
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR adds a single conditional spacing utility to expanded tool rows, separating their output from adjacent hover highlights. It is a localized presentation fix with no changes to data flow, APIs, defaults, or production infrastructure. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe chat timeline adds bottom margin to expanded tool entry rows. ChangesChat layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This visual-only change is ready to merge with no actionable current risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## What's Changed * feat(web): refine compact thread row badges by @maria-rcks in pingdotgg/t3code#11644 * feat(web): show the linked pull request in the compact sidebar rail by @maria-rcks in pingdotgg/t3code#11652 * fix(mobile): adopt system glass for Live Activities by @juliusmarminge in pingdotgg/t3code#11604 * fix(web): separate expanded tool output from adjacent hover highlights by @dominic-r in pingdotgg/t3code#11658 * fix(web): apply device settings to selected environments by @juliusmarminge in pingdotgg/t3code#11541 * feat(server): show finished paragraphs and code blocks while the response streams by @t3dotgg in pingdotgg/t3code#11062 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260913.1675...v0.0.41-nightly.20260914.1687 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260914.1687
Upstream pingdotgg#11658 added a MessagesTimeline test that mounts the component under react-test-renderer, which has no window. The fork's reply navigation effect subscribed unconditionally and threw there. Skip the subscription when there is no window; nothing can dispatch the event without one, so there is nothing to hear.
Hovering a command directly below an expanded tool result made the two backgrounds look joined. Add a 4px bottom margin to expanded rows so the next hover highlight stays separate while collapsed rows keep their existing height.
Verified in a real Chromium client with default dark, Ocean, Grove, Ember, Iris, and T3 Chat. The gap increased from 0.375px to 4.375px; collapsed rows remain 24px, keyboard reopening works, and hover clears on pointer exit. Web and desktop share this component.
Validation: 154 focused timeline tests passed, web typecheck passed, and targeted formatting and lint passed with existing lint warnings.
Before, with the lower command hovered in all six themes:
After, with the same command hovered in all six themes:
Model: GPT-6 Astra. Harness: Codex in T3 Code.