Skip to content

fix(web): separate expanded tool output from adjacent hover highlights - #11658

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
dominic-r:t3code/fix-code-block-hover-bleed
Sep 13, 2026
Merged

fix(web): separate expanded tool output from adjacent hover highlights#11658
maria-rcks merged 1 commit into
pingdotgg:mainfrom
dominic-r:t3code/fix-code-block-hover-bleed

Conversation

@dominic-r

@dominic-r dominic-r commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Hovering a command directly below an expanded tool result made the two backgrounds look joined. Add a 4px bottom margin to expanded rows so the next hover highlight stays separate while collapsed rows keep their existing height.

Verified in a real Chromium client with default dark, Ocean, Grove, Ember, Iris, and T3 Chat. The gap increased from 0.375px to 4.375px; collapsed rows remain 24px, keyboard reopening works, and hover clears on pointer exit. Web and desktop share this component.

Validation: 154 focused timeline tests passed, web typecheck passed, and targeted formatting and lint passed with existing lint warnings.

Before, with the lower command hovered in all six themes:

Before: six themes

After, with the same command hovered in all six themes:

After: six themes

Model: GPT-6 Astra. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 13, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 36fcb9c

Macroscope's review found this PR approvable — This PR adds a single conditional spacing utility to expanded tool rows, separating their output from adjacent hover highlights. It is a localized presentation fix with no changes to data flow, APIs, defaults, or production infrastructure.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 76e4784d-45f8-4428-84eb-c94a7776935e

📥 Commits

Reviewing files that changed from the base of the PR and between 9086a1f and 36fcb9c.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/MessagesTimeline.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The chat timeline adds bottom margin to expanded tool entry rows.

Changes

Chat layout

Layer / File(s) Summary
Expanded row spacing
apps/web/src/components/chat/MessagesTimeline.tsx
PlainWorkEntryRow applies mb-1 when the row is expanded.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 36fcb

This visual-only change is ready to merge with no actionable current risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: separating expanded tool output from adjacent hover highlights.
Description check ✅ Passed The description explains what changed and why, includes before-and-after UI screenshots, and documents validation results. The checklist section is omitted, but the description is otherwise substantia…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit 3689c98 into pingdotgg:main Sep 13, 2026
21 checks passed
@dominic-r
dominic-r deleted the t3code/fix-code-block-hover-bleed branch September 14, 2026 00:02
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 14, 2026
## What's Changed
* feat(web): refine compact thread row badges by @maria-rcks in pingdotgg/t3code#11644
* feat(web): show the linked pull request in the compact sidebar rail by @maria-rcks in pingdotgg/t3code#11652
* fix(mobile): adopt system glass for Live Activities by @juliusmarminge in pingdotgg/t3code#11604
* fix(web): separate expanded tool output from adjacent hover highlights by @dominic-r in pingdotgg/t3code#11658
* fix(web): apply device settings to selected environments by @juliusmarminge in pingdotgg/t3code#11541
* feat(server): show finished paragraphs and code blocks while the response streams by @t3dotgg in pingdotgg/t3code#11062


**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260913.1675...v0.0.41-nightly.20260914.1687

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260914.1687
xiaogwu pushed a commit to xiaogwu/t3code that referenced this pull request Sep 14, 2026
Upstream pingdotgg#11658 added a MessagesTimeline test that mounts the component
under react-test-renderer, which has no window. The fork's reply
navigation effect subscribed unconditionally and threw there. Skip the
subscription when there is no window; nothing can dispatch the event
without one, so there is nothing to hear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants