Skip to content

feat(web): add provider selector to pull request toolbar - #11524

Merged
maria-rcks merged 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/add-provider-filter-icon
Sep 13, 2026
Merged

feat(web): add provider selector to pull request toolbar#11524
maria-rcks merged 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/add-provider-filter-icon

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Adds a provider selector beside Filters and Refresh in the pull request toolbar. The default shows Lucide's Plug2 icon with "All"; choosing a configured host shows its provider icon and reuses the existing host filter.

Verified the label, GitHub selection, return to All, and desktop dark/600px light layouts in the real web client. CI lint, typechecks, and tests passed on d8254cf using Blacksmith. Verified fresh GitHub-scoped results and returning to All against GitHub through the real server and web client.

Before: provider button without the All label

After: Plug2 icon with All

Selecting GitHub and restoring Plug2 with All, at 2x playback

Model: gpt-6. Harness: Codex.

Summary by CodeRabbit

  • New Features
    • Added a provider filter to the pull request list.
    • Added a compact, icon-only filter control when a specific host is selected.
    • Updated the host filter’s “All hosts” option to display as “All.”

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 13, 2026
@maria-rcks
maria-rcks marked this pull request as ready for review September 13, 2026 06:27
@cursor

cursor Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@macroscopeapp

macroscopeapp Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d8254cf

Macroscope's review found this PR approvable — This is a small, self-contained toolbar UI enhancement that exposes an existing provider filter without changing the default selection or backend behavior. The only other changes are presentational menu-label, icon, and compact-control updates.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a74a96a1-f000-43a3-a084-bc36f2b81c3f

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5771d and d8254cf.

📒 Files selected for processing (1)
  • apps/web/src/routes/_chat.pull-requests.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The pull request list adds an inline host filter. CompactFilterMenu now supports icon-only triggers, and the default host option uses Plug2Icon with the label “All”.

Changes

Pull request host filtering

Layer / File(s) Summary
Compact filter menu icon-only behavior
apps/web/src/routes/_chat.pull-requests.tsx
CompactFilterMenu accepts iconOnly, updates its accessibility and title handling, changes the outlined button size, and renders only the selected icon when enabled. The default host option uses Plug2Icon and the label “All”.
Inline host filter wiring
apps/web/src/routes/_chat.pull-requests.tsx
PullRequestsColumn adds an inline provider filter. The filter uses hostMenuOptions, calls onHost, and enables icon-only mode when a host is selected.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to d8254

The provider selector is wired through the existing host filtering and request-scoping paths, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a provider selector to the pull request toolbar.
Description check ✅ Passed The description explains the provider selector behavior, includes UI screenshots and interaction evidence, and records validation results. It does not use the template headings or checklist, and it do…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit 20363c3 into pingdotgg:main Sep 13, 2026
30 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant