Skip to content

fix(web): hide back button for single linked pull requests - #11520

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/hide-single-pr-back-button
Sep 13, 2026
Merged

fix(web): hide back button for single linked pull requests#11520
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/hide-single-pr-back-button

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Hide the linked-pull-request back button when a thread has only one visible linked PR. Threads with multiple visible PRs retain navigation to their list; the standalone pull requests page already omits this button.

Verified in the real web client with GitHub PR data: single-PR thread header hides the arrow, and the standalone PR page has no arrow. Blacksmith web typecheck, scoped lint (existing warnings), and 111 existing PR detail/list tests passed. Multi-PR runtime verification and the CI watcher are blocked by GitHub's rate limit; source review confirms the existing multi-PR action is preserved.

Before:

single linked pr before

After:

single linked pr after

Pull requests page:

pull requests page without back arrow

Implemented with GPT-6 in Codex.

@macroscopeapp

macroscopeapp Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8b143c4

Macroscope's review found this PR approvable — This is a focused one-file UI bug fix that hides an unnecessary back button when a thread has only one visible linked pull request. Existing pull-request availability and data behavior remain unchanged, with no schema, security, infrastructure, or default-setting impact.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fa32294e-8b7d-41dd-80b6-d022485e80c7

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5771d and 8b143c4.

📒 Files selected for processing (1)
  • apps/web/src/components/ChatView.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Pull Request Navigation

Layer / File(s) Summary
Visible pull request navigation
apps/web/src/components/ChatView.tsx
ChatView counts visible pull requests. PullRequestDetailPanel.onBack is supplied only when more than one visible pull request exists.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 8b143

This change safely hides the back button for standalone linked pull requests while preserving navigation for lists with multiple pull requests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the primary change: hiding the back button for a single linked pull request.
Description check ✅ Passed The description explains what changed, why it changed, verification results, limitations, and UI changes with before/after screenshots. It does not use the template headings or include the checklist, …
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 13, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 13, 2026 04:19

Dismissing prior approval to re-evaluate 8b143c4

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Sep 13, 2026
@maria-rcks
maria-rcks merged commit 2ec59ca into pingdotgg:main Sep 13, 2026
21 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 13, 2026
## What's Changed
* feat(web): switch saved environments off instead of removing them by @t3dotgg in pingdotgg/t3code#11478
* fix(mobile): stop crashing on launch when a thread has a PR stack by @juliusmarminge in pingdotgg/t3code#11486
* fix(mobile): stop alerting that shared content vanished after sending it by @juliusmarminge in pingdotgg/t3code#11487
* feat(web): add opt-in thread notifications and sounds by @maria-rcks in pingdotgg/t3code#11481
* fix(server): open Cursor links in classic IDE mode by @Yash-Singh1 in pingdotgg/t3code#11498
* feat(source-control): support Forgejo and Gitea with fj and tea by @maria-rcks in pingdotgg/t3code#11436
* fix(web): match draft row heights to thread rows by @Yash-Singh1 in pingdotgg/t3code#11512
* fix(grok): emit task lifecycle for monitors and background shells by @Svyk in pingdotgg/t3code#9139
* fix(web): unify panel resizing and retain final drag width by @maria-rcks in pingdotgg/t3code#11529
* fix(web): hide back button for single linked pull requests by @maria-rcks in pingdotgg/t3code#11520
* fix(files): browse ignored files and load folders on demand by @maria-rcks in pingdotgg/t3code#11527
* feat(web): float the pull request comment composer by @maria-rcks in pingdotgg/t3code#11531
* fix(mobile): stop crashing on launch before the shell snapshot arrives by @juliusmarminge in pingdotgg/t3code#11537
* feat(github): route pull request operations across matching accounts by @maria-rcks in pingdotgg/t3code#11367
* chore(mobile): enable noUncheckedIndexedAccess and noImplicitOverride by @juliusmarminge in pingdotgg/t3code#11538
* feat(mobile): show startup crashes in Settings → Diagnostics by @juliusmarminge in pingdotgg/t3code#11540
* feat(mobile): add pooled subscription usage widgets by @MatthewFeroz in pingdotgg/t3code#11506

## New Contributors
* @Svyk made their first contribution in pingdotgg/t3code#9139

**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260913.1625...v0.0.41-nightly.20260913.1646

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260913.1646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant