Skip to content

fix(swift-ios): reopened threads no longer show stale history after swipe back #11491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mackinleysmith wants to merge 1 commit into
base: t3code/rebuild-mobile-app-swift
Choose a base branch
from
+10 −1
Open

fix(swift-ios): reopened threads no longer show stale history after swipe back #11491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/swift-ios/Features/Workspace/WorkspaceView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ public struct WorkspaceView: View {
model: model,
thread: thread,
submitMessage: submitMessage,
onNavigateBack: closeSelectedThread
onNavigateBack: collapseToSidebar
)
.id(id)
} else {
Expand Down Expand Up @@ -638,6 +638,15 @@ public struct WorkspaceView: View {
preferredCompactColumn = .sidebar
}

/// Compact-width swipe back. Mirrors the system back button: collapse the
/// column but keep the selection so the thread view is re-shown, not
/// destroyed and recreated. Recreating it inside the split view's
/// interactive pop fires a spurious onDisappear on the next open, which
/// releases the thread mid-load and leaves stale cached content.
private func collapseToSidebar() {
preferredCompactColumn = .sidebar
}

@MainActor
private func openProjectCreation() {
showingNewTask = false
Expand Down
Loading