fix(cursor): preserve internal agent errors without transport labels - #11365
fix(cursor): preserve internal agent errors without transport labels#11365shivamhwp wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The change narrowly corrects Cursor error classification so internal agent-loop diagnostics are preserved instead of being mislabeled as transport failures. It is confined to one classifier with focused regression tests, while existing transport-error handling remains unchanged. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Independent validation of Checked the internal-error diagnostic at every possible two-chunk stream split, with LF/CRLF and optional stack trace: 354 cases. This revision preserved the diagnostic in every case; the merge-base classified every case as a transport failure. Unavailable, aborted, and deadline-exceeded transport diagnostics still classified as failures. Assertions were made after the complete diagnostic arrived. Reproduction scripts and recorded results — Model: GPT-6. Harness: Codex. |
Cursor can return an internal agent-loop error as its assistant answer. T3 currently calls every
RetriableErrora transport failure, including[internal] Failed to run step, exceeded max retries. Preserve internal diagnostics as returned text instead of replacing their meaning with a transport label.Refs #10480. This fixes the classification issue identified in maintainer triage; it does not repair Cursor ACP or add retries.
Validation: 42 focused parser/adapter tests pass. Both new internal-error regressions fail on the parent, including a stack trace. Targeted lint, formatting and diff checks pass. No live Cursor ACP/model request was tested. Internal Fable refinement pending.
Stacked on #11298; only the diagnostic parser and its tests change.
Model and harness: GPT-6 through Codex.