fix(web): show Send beside Stop for desktop follow-ups - #11336
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The change alters the default desktop composer behavior by adding Send beside Stop during running follow-ups, with focused coverage for the new action states. Because this is a customer-visible product-default change, it warrants human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
44d4f9a to
ed6fcc9
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe composer removes the ChangesComposer running actions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The composer now exposes Send alongside Stop for sendable running turns, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Desktop hides Send during an active turn even after a follow-up is typed, although Enter can submit it. Show Send beside Stop whenever the composer has sendable content, using the same submit path and disabled state. An empty running composer still shows only Stop.
Fixes #7750. Rebased onto main. Macroscope requires human review of the changed desktop default. Fable refinement remains pending after the final authorized retry failed.
Verified in an isolated Electron client with a simulated running turn: the base shows Stop only, while this change shows Stop and Send. Clearing and restoring text hides and restores Send, and returning to idle leaves Send only. Clicking Send reached the form submit event, intercepted before any provider request. A 390px responsive web viewport retains both actions. No native mobile change. Web typecheck and seven existing component checks pass; scoped lint exactly matches 35 base warnings.
Before/after images and interaction video are captured. GitHub asset upload is pending while the background browser connection is unavailable.
Model: GPT-6. Harness: Codex.
Rebased on main
20363c32c9bfdbf49c2716ef11d1f18483fcc01b. Scoped validation rerun after rebasing; existing native and human review limits remain.Summary by CodeRabbit
Improvements
Tests