-
Notifications
You must be signed in to change notification settings - Fork 5.6k
feat(web): mark projects on another machine in project pickers #11323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maria-rcks
merged 4 commits into
pingdotgg:main
from
maria-rcks:t3code/show-project-environment-screenshots
Sep 11, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0bca90c
feat(web): show which environment a project lives in inside project p…
fcf9f40
fix(web): pin project environment label order and keep the popup view…
1147bdf
refactor(web): mark remote projects with a machine icon instead of en…
d6a5a2f
fix(web): keep the project machine badge stable and describe it accur…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import type { EnvironmentId, EnvironmentMachineKind } from "@t3tools/contracts"; | ||
|
|
||
| import type { SidebarProjectSnapshot } from "~/sidebarProjectGrouping"; | ||
| import { EnvironmentMachineIcon } from "./EnvironmentMachineIcon"; | ||
| import { Tooltip, TooltipPopup, TooltipTrigger } from "./ui/tooltip"; | ||
|
|
||
| /** | ||
| * Machine icon for a project picker row whose group has a member on another | ||
| * environment, with the environment names in a tooltip. Projects that only | ||
| * live on this device render nothing, the rule thread rows use for their | ||
| * machine icon. Callers | ||
| * render it only while the catalog spans environments (see | ||
| * projectGroupsSpanEnvironments), so single-machine users see no change. | ||
| */ | ||
| export function ProjectEnvironmentBadge(props: { | ||
| readonly group: Pick<SidebarProjectSnapshot, "memberProjects">; | ||
| readonly primaryEnvironmentId: EnvironmentId | null; | ||
| readonly machineByEnvironmentId: ReadonlyMap<EnvironmentId, EnvironmentMachineKind>; | ||
| }) { | ||
| // Member order follows registration order and can differ between sessions, | ||
| // so sort by label to keep the icon and tooltip stable. | ||
| const remoteMembers = props.group.memberProjects | ||
| .filter((member) => member.environmentId !== props.primaryEnvironmentId) | ||
| .map((member) => ({ ...member, environmentLabel: member.environmentLabel ?? "Remote" })) | ||
| .sort((a, b) => a.environmentLabel.localeCompare(b.environmentLabel)); | ||
| const first = remoteMembers[0]; | ||
| if (!first) return null; | ||
| const labels = remoteMembers | ||
| .map((member) => member.environmentLabel) | ||
| .filter((label, index, all) => all.indexOf(label) === index) | ||
| .join(", "); | ||
| const alsoHere = remoteMembers.length < props.group.memberProjects.length; | ||
| const description = `${alsoHere ? "Also on" : "On"} ${labels}`; | ||
| return ( | ||
| <Tooltip> | ||
| <TooltipTrigger | ||
| render={ | ||
| <span | ||
| role="img" | ||
| aria-label={description} | ||
| className="ml-auto inline-flex shrink-0 items-center text-muted-foreground" | ||
| /> | ||
| } | ||
| > | ||
| <EnvironmentMachineIcon | ||
| aria-hidden | ||
| kind={props.machineByEnvironmentId.get(first.environmentId) ?? "server"} | ||
| className="size-3.5" | ||
| /> | ||
| </TooltipTrigger> | ||
| <TooltipPopup side="top">{description}</TooltipPopup> | ||
| </Tooltip> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.