Repository navigation
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This narrowly scoped fix changes only failed provider-version lookups to retry after one minute instead of remaining cached for an hour; successful lookups remain cached for an hour. A focused regression test covers the retry and recovery behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughFailed npm registry lookups now expire from the latest-version cache after 60 seconds. Successful lookups retain a one-hour expiry. Tests verify the failed lookup, retry window, and later successful lookup. ChangesProvider version retry behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to Failed provider version checks retry after one minute while successful results remain cached for an hour. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks for the PR. We're not taking changes to the orchestration and provider layers right now: that part of the server is being rewritten for V2, and merging into the current code would either conflict with or be thrown away by that work. Closing for now. If this is still an issue once V2 lands, please reopen (or open a fresh PR against the new code) and we'll take a proper look. |
The provider update prompt depends on
resolveLatestProviderVersion, which asks the npm registry for the latest version under a 4 s timeout. When that single request times out (a cold DNS lookup on a filtering resolver can take over 10 s) or fails, thenullresult is cached for the full one-hour TTL, soderiveVersionAdvisorystaysunknownand the "update available" toast never appears, even though the next lookup would take well under a second.A failed or timed-out lookup is now cached for one minute instead of an hour, so the next provider probe retries it. Successful lookups keep the hour-long cache, and the request timeout is unchanged.
Verification
providerMaintenance.test.ts: a 503 from the registry yieldsnullwith a 60 s cache entry, the failure is still served from cache inside that minute, and after the test clock passes it a 200 response resolves2.0.0with the hour-long entry.vp test run apps/server/src/provider/providerMaintenance.test.ts: the new test and the existing cache tests pass. Two npm-ownership tests in that file fail identically on an untouchedmaincheckout on this machine (they depend on the local npm prefix), so they are unrelated.Fixes #11163. Implemented with Claude Code (Claude Fable 5.1).
Summary by CodeRabbit