Skip to content

fix(mobile): match Working status color to desktop - #10515

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
baptisteArno:t3code/blue-working-status-mobile
Sep 7, 2026
Merged

fix(mobile): match Working status color to desktop#10515
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
baptisteArno:t3code/blue-working-status-mobile

Conversation

@baptisteArno

@baptisteArno baptisteArno commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What Changed

Use the existing adaptive sky color for the Working label in both mobile thread lists.

Why

Working was rendered in secondary gray on mobile while the desktop sidebar uses blue. The existing token provides sky-600 in light mode and sky-400 in dark mode, including custom mobile themes.

UI Changes

Captured on an iPhone 17 simulator (iOS 26.5) with an isolated demo environment.

Appearance Before After
Light Before: gray Working label in light mode After: blue Working label in light mode
Dark Before: gray Working label in dark mode After: blue Working label in dark mode

Validation

  • iOS simulator build and visual verification in light and dark mode.
  • Targeted lint: no errors; two existing dependency warnings.
  • Formatting and git diff checks passed.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for UI changes

Implemented with GPT-6, using the Codex harness in T3 Code.

Note

Fix mobile 'Working' thread status color to match desktop

Changes the text class for working and running thread statuses from secondary foreground to adaptive sky in thread-list-v2-items.tsx and threadPresentation.ts. This aligns the mobile thread list colors with the desktop app.

Macroscope summarized 190211b.

Summary by CodeRabbit

  • Style
    • Updated the “Working” status label in thread lists to use the adaptive sky color for improved visual consistency.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 190211b

Macroscope's review found this PR approvable — This is a focused mobile presentation fix that replaces gray Working-status text with an existing adaptive sky color in both relevant render paths. It does not change status logic, data flow, settings, or downstream behavior.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 6fb1e989-5ea3-4e8f-bfd7-cd89dedc3ca6

📥 Commits

Reviewing files that changed from the base of the PR and between 8b2838e and 190211b.

📒 Files selected for processing (2)
  • apps/mobile/src/features/threads/thread-list-v2-items.tsx
  • apps/mobile/src/features/threads/threadPresentation.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Working status label now uses text-adaptive-sky-600-400 in both mobile thread status presentation paths.

Changes

Working status color

Layer / File(s) Summary
Update Working status color
apps/mobile/src/features/threads/thread-list-v2-items.tsx, apps/mobile/src/features/threads/threadPresentation.ts
The Working status uses text-adaptive-sky-600-400 instead of text-foreground-secondary.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 19021

Working labels in both mobile thread-list paths now use the adaptive sky color, aligning active-status styling across themes. No merge-blocking risk remains.

Suggested reviewers: juliusmarminge, t3dotgg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: matching the mobile Working status color to the desktop implementation.
Description check ✅ Passed The description includes What Changed, Why, UI Changes with before/after screenshots, validation details, and the completed checklist. It is focused and consistent with the pull request objectives.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit 357b8d5 into pingdotgg:main Sep 7, 2026
10 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 7, 2026
## What's Changed
* feat(web): group onboarding project import by repository by @t3dotgg in pingdotgg/t3code#10493
* fix(web): remove inserted citations on cancel by @extoci in pingdotgg/t3code#10518
* fix(mobile): match Working status color to desktop by @baptisteArno in pingdotgg/t3code#10515

## New Contributors
* @baptisteArno made their first contribution in pingdotgg/t3code#10515

**Full Changelog**: pingdotgg/t3code@v0.0.40-nightly.20260907.1346...v0.0.40-nightly.20260907.1359

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.40-nightly.20260907.1359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants