fix(mobile): animate thread lifecycle transitions consistently - #10487
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This mobile fix coordinates dismissal animations across multiple visible thread rows and changes timing and rollback behavior for archive, delete, settle, snooze, and wake actions. Because it introduces shared asynchronous lifecycle state across several production list surfaces, the change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThread dismissal now coordinates visible row copies by composite thread key. Mutations wait for dismissal animations, restore rows on unsuccessful outcomes, and use lifecycle-aware swipe reset keys. ChangesThread dismissal coordination
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The updated dismissal flow has no confirmed merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant User
participant ThreadSwipeable
participant withThreadDismissal
participant ThreadMutation
User->>ThreadSwipeable: trigger thread action
ThreadSwipeable->>withThreadDismissal: request keyed dismissal
withThreadDismissal->>ThreadSwipeable: dismiss visible copies
ThreadSwipeable-->>withThreadDismissal: report animation completion
withThreadDismissal->>ThreadMutation: run mutation
ThreadMutation-->>withThreadDismissal: return result
withThreadDismissal->>ThreadSwipeable: restore rows if unsuccessful
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
## What's Changed * fix(mobile): keep pending messages in the chat timeline by @juliusmarminge in pingdotgg/t3code#10449 * fix(mobile): show connection status in the floating pill instead of a second one by @juliusmarminge in pingdotgg/t3code#10440 * fix: use Pierre icons consistently for attachments by @juliusmarminge in pingdotgg/t3code#10475 * feat(mobile): open the thread screen as soon as a new task is submitted by @juliusmarminge in pingdotgg/t3code#10435 * fix(devcontainer): make repository setup work by @saphid in pingdotgg/t3code#7875 * fix(projects): prevent invalid script IDs from crashing threads by @saphid in pingdotgg/t3code#10019 * fix(mobile): hide changed-files navigator and restore refresh in raw diff fallback by @lnieuwenhuis in pingdotgg/t3code#9828 * fix(ios): scroll short source files from blank space by @juliusmarminge in pingdotgg/t3code#10178 * feat(mobile): start a new thread on an existing branch by @StiensWout in pingdotgg/t3code#10359 * fix(mobile): improve font-size slider performance and prevent maximum update depth errors by @bbernag in pingdotgg/t3code#7138 * fix(web): keep composer toolbar controls anchored during transitions by @juliusmarminge in pingdotgg/t3code#10478 * fix(web): resize the floating preview from any edge by @juliusmarminge in pingdotgg/t3code#10467 * fix(mobile): prevent chat from disappearing when scrolling by @juliusmarminge in pingdotgg/t3code#10479 * fix(mobile): smooth composer status pill resizing by @juliusmarminge in pingdotgg/t3code#10484 * fix(mobile): release initial scroll target after dragging by @juliusmarminge in pingdotgg/t3code#10483 * fix(mobile): animate thread lifecycle transitions consistently by @juliusmarminge in pingdotgg/t3code#10487 * fix(mobile): restore assistant message bottom padding by @juliusmarminge in pingdotgg/t3code#10491 * fix(mobile): preserve chat rows when toggling commands by @juliusmarminge in pingdotgg/t3code#10492 ## New Contributors * @bbernag made their first contribution in pingdotgg/t3code#7138 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260907.1332...v0.0.40-nightly.20260907.1346 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.40-nightly.20260907.1346
* origin/main: (675 commits) fix(web): tolerate servers that predate git identity in project import (pingdotgg#10547) chore(mobile): bump app version to 1.1.0 fix(mobile): wait for native thread scroll before reveal (pingdotgg#10486) fix(mobile): match Working status color to desktop fix(web): remove inserted citations on cancel (pingdotgg#10518) feat(web): group onboarding project import by repository (pingdotgg#10493) fix(mobile): preserve chat rows when toggling commands (pingdotgg#10492) fix(mobile): restore assistant message bottom padding (pingdotgg#10491) fix(mobile): animate thread lifecycle transitions consistently (pingdotgg#10487) fix(mobile): release initial scroll target after dragging (pingdotgg#10483) fix(mobile): smooth composer status pill resizing (pingdotgg#10484) fix(mobile): prevent chat from disappearing when scrolling (pingdotgg#10479) fix(web): resize the floating preview from any edge (pingdotgg#10467) fix(web): keep composer toolbar controls anchored during transitions (pingdotgg#10478) fix(mobile): improve font-size slider performance and prevent maximum update depth errors (pingdotgg#7138) feat(mobile): start a new thread on an existing branch (pingdotgg#10359) fix(ios): scroll short source files from blank space (pingdotgg#10178) fix(mobile): hide changed-files navigator and restore refresh in raw diff fallback (pingdotgg#9828) fix(projects): prevent invalid script IDs from crashing threads (pingdotgg#10019) fix(devcontainer): make repository setup work (pingdotgg#7875) ... # Conflicts: # apps/server/src/provider/builtInDrivers.ts # docs/README.md # docs/user/install.md # packages/contracts/src/settings.test.ts # packages/contracts/src/settings.ts
What Changed
Mobile thread lifecycle actions now finish the existing slide-out and collapse animation before updating the list. Swipe and menu actions share it across Home, the thread sidebar, and Archive, including delete, archive, settle, snooze, wake, un-settle, and unarchive. Deletion still waits for confirmation, failures restore rows, and recycling a row does not strand its command.
Why
Only the Settle swipe button animated its row away. Other actions abruptly replaced the row and moved its neighbors. Registering visible rows with the shared action flow applies the same transition regardless of where an action starts.
Validation: four focused dismissal tests pass, the mobile TypeScript check passes, and targeted lint completes with warnings. On an iPhone 17e simulator running iOS 26.5, verified snooze, confirmed deletion, full-swipe settle, un-settle, and wake against a disposable server. Archive and sidebar wiring were reviewed in source. No wire contracts, provider adapters, web, or desktop behavior changed.
UI Changes
Same simulator, viewport, project, and thread restored between captures. Before uses c0d4e95; after uses 4c3b4b5. The final layout is the same; the recording shows the transition difference. Captures are cropped to the affected list area.
Before and after screenshots:
Before and after recording, shown at half speed:
Download the comparison video
Checklist
Implemented with GPT-6 through Codex.