fix(web): discard new citations when cancelled - #10381
Closed
Neel2107 wants to merge 1 commit into
Closed
Conversation
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a focused web bug fix that changes only citation-comment cancellation behavior, preserving existing drafts and removing unfinished citations without affecting saved citations. The implementation is localized and backed by targeted tests covering the main draft and editing scenarios. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
Member
|
Superseded by #10518, which landed the same fix (remove inserted citations on cancel). Closing this as superseded — feel free to reopen if anything was missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a newly selected citation closed the comment popover but left its chip in the composer. Cancel, Escape, and outside dismissal now discard the pending citation and restore the original draft, including its spacing. If the draft changed meanwhile, only the pending citation is removed. Cancelling a comment edit on a saved citation preserves the citation and its original comment.
Closes #10379.
Validation:
Model: GPT-6. Harness: Codex.