Skip to content

fix(server): keep provider inventories consistent after refresh - #10292

Closed
t3dotgg wants to merge 6 commits into
t3code/debt-gzuf-2-adapter-compactionfrom
t3code/debt-gzuf-6-discovery
Closed

t3dotgg wants to merge 6 commits into
t3code/debt-gzuf-2-adapter-compactionfrom
t3code/debt-gzuf-6-discovery

fix(server): reject stale account scans and retain usable skills

c9fbc74
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Sep 6, 2026 in 1m 22s

No issues identified (3 code objects reviewed).

• Reviewed files modified since c7ced55; other PR files not modified since then were skipped.
• Merge Base: 58c0c98
• Head: c9fbc74

Details

✅ File Path U3 Bytes Comments Posted Reason
✅ apps/server/src/provider/Drivers/AntigravityDriver.ts 1530 0
➖ apps/server/src/provider/Layers/AntigravityProvider.test.ts 2183 Excluded by default ignore patterns
✅ apps/server/src/provider/Layers/ProviderRegistry.ts 2012 0
✅ apps/server/src/provider/Layers/AntigravityProvider.ts 1483 0
➖ apps/server/src/provider/Layers/ProviderRegistry.test.ts 847 Excluded by default ignore patterns

Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/server/src/provider/Layers/ProviderRegistry.ts
  • line 203: When a legacy workspace snapshot omits its optional inventory, this call treats both command and skill lists as authoritative because mergeProviderWorkspaceInventories only retains old values for an explicit "stale" state. Thus a partial old-server refresh with (for example) skills: [] overwrites a previously cached workspace skill list, whereas the provider-level model merge explicitly defaults absent inventory to stale. The schema permits workspace inventory to be absent, so older producers can silently erase cached workspace discoveries. [ Already posted ]