Skip to content

fix(mobile): save linked media from chat - #10271

Merged
juliusmarminge merged 3 commits into
mainfrom
t3code/update-maria-counter-video
Sep 6, 2026
Merged

juliusmarminge merged 3 commits into
mainfrom
t3code/update-maria-counter-video

fix(mobile): keep file sharing callbacks current after reconnect

cbb5886
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Sep 6, 2026 in 1m 31s

No issues identified (3 code objects reviewed).

• Reviewed files modified since 05f4fca; other PR files not modified since then were skipped.
• Merge Base: cb9a694
• Head: cbb5886

Details

✅ File Path U3 Bytes Comments Posted Reason
✅ apps/mobile/src/features/threads/useFileChipShare.ts 1666 0
➖ apps/mobile/src/features/threads/fileChipMenu.test.ts 240 Excluded by default ignore patterns
✅ apps/mobile/src/features/threads/fileChipMenu.ts 610 0
✅ apps/mobile/src/features/threads/ThreadFeed.tsx 1459 0

Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/mobile/src/features/threads/useFileChipShare.ts
  • line 35: requestRef is only aborted on component unmount, but ThreadFeed deliberately stays mounted when its environmentId/threadId changes (it resets state using feedThreadKey). If a save request is still awaiting URL creation or download when the user switches threads, the new thread's share callback reaches this guard with the old controller still set and silently ignores every Save action until that unrelated request finishes; the old request can also subsequently present its share sheet over the newly selected thread. Abort and clear the request when the target environment/thread changes. [ Previously rejected ]