Skip to content

refactor(contracts): keep unused settings and relay exports private #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Sep 5, 2026
+18 −18
Merged

refactor(contracts): keep unused settings and relay exports private #10170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa6454
refactor(contracts): keep domain schema internals private
juliusmarminge Sep 5, 2026
b37eb8e
refactor(contracts): retain domain schemas and types
juliusmarminge Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/contracts/src/relay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ export const RelayHealthResponse = Schema.Struct({
});
export type RelayHealthResponse = typeof RelayHealthResponse.Type;

export const RelayHealthGroup = HttpApiGroup.make("health")
const RelayHealthGroup = HttpApiGroup.make("health")
.add(
HttpApiEndpoint.get("health", "/health", {
success: RelayHealthResponse,
Expand All @@ -884,7 +884,7 @@ export const RelayHealthGroup = HttpApiGroup.make("health")
)
.annotate(OpenApi.Description, "Service health and readiness.");

export const RelayMetadataGroup = HttpApiGroup.make("metadata")
const RelayMetadataGroup = HttpApiGroup.make("metadata")
.add(
HttpApiEndpoint.get("authorizationServer", "/.well-known/oauth-authorization-server", {
success: RelayAuthorizationServerMetadata,
Expand Down Expand Up @@ -946,7 +946,7 @@ export const RelayUnregisterDeviceEndpoint = HttpApiEndpoint.delete(
},
).annotate(OpenApi.Summary, "Unregister a mobile device");

export const RelayMobileGroup = HttpApiGroup.make("mobile")
const RelayMobileGroup = HttpApiGroup.make("mobile")
.add(
RelayRegisterDeviceEndpoint,
RelayRegisterLiveActivityEndpoint,
Expand All @@ -956,7 +956,7 @@ export const RelayMobileGroup = HttpApiGroup.make("mobile")
.annotate(OpenApi.Description, "Mobile push-notification and Live Activity registration.")
.middleware(RelayDpopClientAuth);

export const RelayClientGroup = HttpApiGroup.make("client")
const RelayClientGroup = HttpApiGroup.make("client")
.add(
HttpApiEndpoint.get("listEnvironments", "/v1/environments", {
headers: RelayBearerRequestHeaders,
Expand Down Expand Up @@ -1025,7 +1025,7 @@ export const RelayExchangeDpopAccessTokenEndpoint = HttpApiEndpoint.post(
"Bootstrap endpoint. Send the DPoP proof JWT in the dpop header and the Clerk token in subject_token. The returned access token is bound to the proof key.",
);

export const RelayTokenGroup = HttpApiGroup.make("token")
const RelayTokenGroup = HttpApiGroup.make("token")
.add(RelayExchangeDpopAccessTokenEndpoint)
.annotate(OpenApi.Description, "OAuth token exchange for DPoP-bound client access.");

Expand Down Expand Up @@ -1056,12 +1056,12 @@ export const RelayGetEnvironmentStatusEndpoint = HttpApiEndpoint.post(
},
).annotate(OpenApi.Summary, "Check environment status");

export const RelayDpopClientGroup = HttpApiGroup.make("dpopClient")
const RelayDpopClientGroup = HttpApiGroup.make("dpopClient")
.add(RelayConnectEnvironmentEndpoint, RelayGetEnvironmentStatusEndpoint)
.annotate(OpenApi.Description, "DPoP-authenticated client access to linked environments.")
.middleware(RelayDpopClientAuth);

export const RelayServerGroup = HttpApiGroup.make("server")
const RelayServerGroup = HttpApiGroup.make("server")
.add(
HttpApiEndpoint.post(
"publishAgentActivity",
Expand Down
22 changes: 11 additions & 11 deletions packages/contracts/src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ import {

export const TimestampFormat = Schema.Literals(["locale", "12-hour", "24-hour"]);
export type TimestampFormat = typeof TimestampFormat.Type;
export const DEFAULT_TIMESTAMP_FORMAT: TimestampFormat = "locale";
const DEFAULT_TIMESTAMP_FORMAT: TimestampFormat = "locale";

export const DiffLayout = Schema.Literals(["stacked", "split"]);
export type DiffLayout = typeof DiffLayout.Type;
export const DEFAULT_DIFF_LAYOUT: DiffLayout = "stacked";
const DEFAULT_DIFF_LAYOUT: DiffLayout = "stacked";

export const SidebarProjectSortOrder = Schema.Literals(["updated_at", "created_at", "manual"]);
export type SidebarProjectSortOrder = typeof SidebarProjectSortOrder.Type;
Expand All @@ -51,7 +51,7 @@ export const SidebarProjectGroupingMode = Schema.Literals([
"separate",
]);
export type SidebarProjectGroupingMode = typeof SidebarProjectGroupingMode.Type;
export const DEFAULT_SIDEBAR_PROJECT_GROUPING_MODE: SidebarProjectGroupingMode = "repository";
const DEFAULT_SIDEBAR_PROJECT_GROUPING_MODE: SidebarProjectGroupingMode = "repository";
export const MIN_SIDEBAR_THREAD_PREVIEW_COUNT = 1;
export const MAX_SIDEBAR_THREAD_PREVIEW_COUNT = 15;
export const SidebarThreadPreviewCount = Schema.Int.check(
Expand All @@ -61,7 +61,7 @@ export const SidebarThreadPreviewCount = Schema.Int.check(
}),
);
export type SidebarThreadPreviewCount = typeof SidebarThreadPreviewCount.Type;
export const DEFAULT_SIDEBAR_THREAD_PREVIEW_COUNT: SidebarThreadPreviewCount = 6;
const DEFAULT_SIDEBAR_THREAD_PREVIEW_COUNT: SidebarThreadPreviewCount = 6;
export const MIN_SIDEBAR_AUTO_SETTLE_AFTER_DAYS = 1;
export const MAX_SIDEBAR_AUTO_SETTLE_AFTER_DAYS = 90;
export const SidebarAutoSettleAfterDays = Schema.Number.check(
Expand All @@ -71,7 +71,7 @@ export const SidebarAutoSettleAfterDays = Schema.Number.check(
}),
);
export type SidebarAutoSettleAfterDays = typeof SidebarAutoSettleAfterDays.Type;
export const DEFAULT_SIDEBAR_AUTO_SETTLE_AFTER_DAYS: SidebarAutoSettleAfterDays = 3;
const DEFAULT_SIDEBAR_AUTO_SETTLE_AFTER_DAYS: SidebarAutoSettleAfterDays = 3;
export const MIN_GLASS_OPACITY = 40;
export const MAX_GLASS_OPACITY = 100;
export const GlassOpacity = Schema.Int.check(
Expand All @@ -81,15 +81,15 @@ export const GlassOpacity = Schema.Int.check(
}),
);
export type GlassOpacity = typeof GlassOpacity.Type;
export const DEFAULT_GLASS_OPACITY: GlassOpacity = 80;
const DEFAULT_GLASS_OPACITY: GlassOpacity = 80;

export const MIN_APPEARANCE_CONTRAST = 50;
export const MAX_APPEARANCE_CONTRAST = 200;
export const AppearanceContrast = Schema.Int.check(
Schema.isBetween({ minimum: MIN_APPEARANCE_CONTRAST, maximum: MAX_APPEARANCE_CONTRAST }),
);
export type AppearanceContrast = typeof AppearanceContrast.Type;
export const DEFAULT_APPEARANCE_CONTRAST: AppearanceContrast = 100;
const DEFAULT_APPEARANCE_CONTRAST: AppearanceContrast = 100;
export const MIN_PANEL_ANIMATION_DURATION_MS = 0;
export const MAX_PANEL_ANIMATION_DURATION_MS = 400;
export const PanelAnimationDurationMs = Schema.Int.check(
Expand All @@ -99,7 +99,7 @@ export const PanelAnimationDurationMs = Schema.Int.check(
}),
);
export type PanelAnimationDurationMs = typeof PanelAnimationDurationMs.Type;
export const DEFAULT_PANEL_ANIMATION_DURATION_MS: PanelAnimationDurationMs = 0;
const DEFAULT_PANEL_ANIMATION_DURATION_MS: PanelAnimationDurationMs = 0;
/**
* Font size preferences, in CSS pixels. The ranges are deliberately narrow:
* the interface size scales every rem-based dimension in the app, so the
Expand Down Expand Up @@ -135,15 +135,15 @@ export const TerminalFontSize = Schema.Int.check(
Schema.isBetween({ minimum: MIN_TERMINAL_FONT_SIZE, maximum: MAX_TERMINAL_FONT_SIZE }),
);
export type TerminalFontSize = typeof TerminalFontSize.Type;
export const DEFAULT_TERMINAL_FONT_SIZE: TerminalFontSize = 12;
const DEFAULT_TERMINAL_FONT_SIZE: TerminalFontSize = 12;

export const EnvironmentIdentificationMode = Schema.Literals(["artwork", "pill", "none"]);
export type EnvironmentIdentificationMode = typeof EnvironmentIdentificationMode.Type;
export const DEFAULT_ENVIRONMENT_IDENTIFICATION_MODE: EnvironmentIdentificationMode = "artwork";

export const QuitConfirmationMode = Schema.Literals(["direct", "hold", "double-click"]);
export type QuitConfirmationMode = typeof QuitConfirmationMode.Type;
export const DEFAULT_QUIT_CONFIRMATION_MODE: QuitConfirmationMode = "hold";
const DEFAULT_QUIT_CONFIRMATION_MODE: QuitConfirmationMode = "hold";

const LegacyConfirmQuit = Schema.Boolean.pipe(
Schema.decodeTo(
Expand Down Expand Up @@ -423,7 +423,7 @@ export type ProviderSettingsOrder<Fields extends Schema.Struct.Fields> = readonl
string
>[];

export function makeProviderSettingsSchema<const Fields extends Schema.Struct.Fields>(
function makeProviderSettingsSchema<const Fields extends Schema.Struct.Fields>(
fields: Fields,
options?: {
readonly order?: ProviderSettingsOrder<Fields> | undefined;
Expand Down
Loading