Skip to content

fix(server): settle inactive threads without a PR lookup - #10103

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/debt-gzuf-3-server-pr-state
Sep 6, 2026
Merged

fix(server): settle inactive threads without a PR lookup#10103
t3dotgg merged 1 commit into
mainfrom
t3code/debt-gzuf-3-server-pr-state

fix(server): settle inactive threads without a PR lookup

c152498
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 6, 2026 in 2m 16s

Effect Service Conventions: no issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed apps/server/src/orchestration/ThreadSettlementReactor.ts (the only in-scope changed file; ThreadSettlementReactor.test.ts is excluded by the check's patterns).

Checked:

  • Imports: all Effect modules already imported as namespaces from subpaths; local service modules (GitManager, PullRequestService, ServerSettings, OrchestrationEngine, ProjectionSnapshotQuery) imported as namespaces; named imports limited to pure helpers/types (ThreadSettlementPolicy, @t3tools/contracts). No changes here.
  • Service definition: unchanged Context.Service tag with inline interface, make, then layer; new settleThread is a local Effect.fn inside sweep, not a new service or shape interface.
  • Dependency acquisition: settleThread closes over services obtained with yield* Foo.Foo in make; no service instances passed as parameters (pullRequest: SettlementPullRequest | null is an immutable domain value), no module globals, no ManagedRuntime/runPromise introduced.
  • Errors: no new error classes, factories, predicates, or catch operators added; the relocated Effect.catchCause + Cause.hasInterruptsOnly handling is the file's pre-existing pattern moved verbatim.
  • Change discipline: no new lint/type-checker suppressions; the behavior change (settling inactive threads before host-dependent lookups) is covered by two new focused tests that stub only external lookups via the existing harness layers.
🔍 Agent activity — 1 tool call

1. browse_code — apps/server/src/orchestration/ThreadSettlementReactor.ts

💭 I notice Map.groupBy is a valid JS builtin, so that's fine as pre-existing code. Checking the changed lines for convention issues—imports look unchanged, no new errors introduced, though the test's use of a detail field on PullRequestOperationError catches my eye since that's outside the scope but worth flagging as a possible convention violation. Looking closer at settleThread and lookupCandidates, the Effect.catchCause usage seems like a pre-existing pattern rather than something newly introduced, and the concurrency settings and thread-or-null return look reasonable. The ThreadSettlementPolicy imports are unchanged pure helpers, so nothing stands out there either—overall this looks clean with no real findings to report. I do notice Cause.pretty(cause) being logged in the moved code, which technically touches on the "no arbitrary defect text in log annotations" guidance, but since this is a relocation of an existing repo-wide pattern rather than something newly introduced, flagging it would demand a broader cleanup beyond scope. I'll leave that unflagged and finalize with "All clear" as the summary.

Agent Credits: 22 credits

Token usage: 4 uncached input · 18,450 cache-read input · 23,535 cache-write input · 1,830 output
Agent Credits may also include non-token charges from external tools such as web research.

View more details on MacroscopeApp