refactor(web): test live Ghostty link resolution directly - #10041
Effect Service Conventions: no issues found
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
The only in-scope changed file is apps/web/src/terminal/ghostty/surface.ts (the test file is excluded by the check's exclude patterns). The change removes two thin wrapper functions (terminalLinkAtPosition, terminalLinkAtColumn) around terminalLinkAtPositionWithRange and updates callers. Verified no remaining references to the removed identifiers anywhere in the repository, and the sole production call site uses terminalLinkAtPositionWithRange directly. No Effect service, layer, error, or runtime code is created, moved, or consumed by these changes, so none of the Effect service conventions apply.
🔍 Agent activity — 2 tool calls
💭 The diff removes the
terminalLinkAtPositionandterminalLinkAtColumnwrapper functions from surface.ts and updates the tests accordingly. I should verify there aren't other consumers of these functions still relying on them elsewhere in the repo.
1. browse_code — Find all usages/references of terminalLinkAtPosition and terminalLinkAtColumn and terminalLinkAtPositionWithRange across the repository (any file). List file paths and line contents.
2. browse_code — apps/web/src/terminal/ghostty/surface.ts
💭 This PR looks like a pure test and wrapper cleanup, with nothing touching Effect service logic, so there's nothing to flag here.
Agent Credits: 181 credits
Token usage: 32 uncached input · 750,041 cache-read input · 177,127 cache-write input · 9,590 output
Agent Credits may also include non-token charges from external tools such as web research.