Skip to content

refactor(web): remove unused desktop update visibility helper - #10014

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/cleanup-unused-desktop-update-visibility
Sep 5, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3code/cleanup-unused-desktop-update-visibility

refactor(web): remove unused desktop update visibility helper

1a7068b
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Sep 5, 2026 in 2m 57s

Effect Service Conventions: No issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

The PR removes the unused shouldShowDesktopUpdateButton helper from apps/web/src/components/desktopUpdate.logic.ts and the corresponding assertions from its test file (out of scope per exclude patterns). Verified no remaining references to the removed symbol exist in the repository. The changed code contains no Effect service definitions, imports, layers, runtimes, or error classes, so none of the Effect service conventions apply.


🔍 Agent activity — 1 tool call

💭 This diff removes the unused shouldShowDesktopUpdateButton function along with its test cases, touching only the logic file and its test. I should double-check there are no remaining consumers of this function elsewhere in the codebase before confirming the removal is safe.

1. browse_code — Is shouldShowDesktopUpdateButton referenced anywhere in the repository (outside apps/web/src/components/desktopUpdate.logic.ts)? Also show the current contents of apps/web/src/components/desktopUpdate.logic.ts.

💭 This is just dead code removal, no Effect service concerns to flag here.


Agent Credits: 45 credits

Token usage: 16 uncached input · 70,050 cache-read input · 38,174 cache-write input · 6,163 output
Agent Credits may also include non-token charges from external tools such as web research.