Skip to content

fix(android): a long-press drag selection is no longer stolen by a scrolling parent #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 16, 2026
Merged

fix(android): a long-press drag selection is no longer stolen by a scrolling parent #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...kdown/android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkEvents.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ fun TextView.cancelJSTouchForLinkTap(event: MotionEvent) {
val currentMovementMethod = movementMethod
if (currentMovementMethod is LinkLongPressMovementMethod && currentMovementMethod.isLinkTouchActive) {
parent?.requestDisallowInterceptTouchEvent(true)
currentMovementMethod.disallowsParentIntercept = true
NativeGestureUtil.notifyNativeGestureStarted(this, event)
}
}
Expand All @@ -56,12 +57,21 @@ fun TextView.cancelJSTouchForLinkTap(event: MotionEvent) {
* touch is no longer active (slop exceeded, gesture ended, or cancelled).
* This restores normal scrolling behavior for parent ScrollView/RecyclerView.
*
* Only undoes the request made by [cancelJSTouchForLinkTap]. A long-press
* drag selection makes the framework Editor ask the parents not to intercept
* until ACTION_UP; re-allowing on every move let a scrolling parent steal
* that drag and cancel the selection before its handles and toolbar showed.
*
* Must be called after [LinkLongPressMovementMethod.onTouchEvent] has
* processed the event, since that is where [isLinkTouchActive] is updated.
*/
fun TextView.reallowParentInterceptIfLinkReleased() {
val currentMovementMethod = movementMethod
if (currentMovementMethod is LinkLongPressMovementMethod && !currentMovementMethod.isLinkTouchActive) {
if (currentMovementMethod is LinkLongPressMovementMethod &&
currentMovementMethod.disallowsParentIntercept &&
!currentMovementMethod.isLinkTouchActive
) {
currentMovementMethod.disallowsParentIntercept = false
parent?.requestDisallowInterceptTouchEvent(false)
}
}
Expand Down
3 changes: 3 additions & 0 deletions .../main/java/com/swmansion/enriched/markdown/utils/text/view/LinkLongPressMovementMethod.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {

var isLinkTouchActive: Boolean = false
private set

/** True while the host view has asked its parents not to intercept for a link press. */
var disallowsParentIntercept: Boolean = false
private var isTouchWithinTextBounds: Boolean = true

override fun onTouchEvent(
Expand Down