[FLASH-546] Fix exception after reload PageStorage from disk #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the won't decrease of Normal Page in PageStorage Add more test case for checking the ref-count of NormalPage
|
/build |
|
/rebuild |
|
/run-integration-tests |
flowbehappy
approved these changes
Oct 12, 2019
|
LGTM |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 17, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 18, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
that referenced
this pull request
Oct 22, 2019
* Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 23, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 30, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 5, 2019
…#274) * Idempotent del for PageStorage * Fix the won't decrease of Normal Page in PageStorage * Add more test case for checking the ref-count of NormalPage * add metrics: PSMVCCNumSnapshots
Lloyd-Pottiger
pushed a commit
to Lloyd-Pottiger/tiflash
that referenced
this pull request
Sep 20, 2024
CalvinNeo
pushed a commit
to CalvinNeo/tiflash
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
"select * from metrics where system.metric = 'PSMVCCNumSnapshots'"to see the num of PageStorage's snapshots