Binary compatibility version for DeltaMerge's chunk; Fix disappear of PageStorage del meta #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
flowbehappy
approved these changes
Sep 27, 2019
|
LGTM |
|
/run-integration-tests |
JaySon-Huang
force-pushed
the
dm-pagestorage-fix
branch
from
d9c80dd to
f5f44e6
Compare
This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
force-pushed
the
dm-pagestorage-fix
branch
from
f5f44e6 to
1d6e0f1
Compare
|
/run-integration-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 17, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 18, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
that referenced
this pull request
Oct 22, 2019
… PageStorage del meta (#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 23, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 30, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 5, 2019
… PageStorage del meta (pingcap#257) * Chunk binary version * Add name to PageStorage for identify different storages * Remove getMaxId of PageStorage * Migrate DelPage mark in doing GC * enable fullstack-test * Revert "Remove getMaxId of PageStorage" This reverts commit 34d50eb6e9fb2f229f32e2d6b219b74c340d0d0a.
JaySon-Huang
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: Wish <[email protected]>
JaySon-Huang
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: Wish <[email protected]>
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 7, 2024
Signed-off-by: Wish <[email protected]>
Lloyd-Pottiger
pushed a commit
to Lloyd-Pottiger/tiflash
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Wish <[email protected]>
Lloyd-Pottiger
pushed a commit
to Lloyd-Pottiger/tiflash
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Wish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeltaMerge
PageStorage
Remove getMaxId of PageStorage. We just need the max Page ID when we load PageStorage from disk, removing this API so that we can ignore max ID when putting new Page.