[flash-487] support compare and some cast functions #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windtalker
reviewed
Sep 18, 2019
| || (left_is_date = checkAndGetDataType<DataTypeDate>(arguments[0].get())) | ||
| || (left_is_date_time = checkAndGetDataType<DataTypeDateTime>(arguments[0].get())) | ||
| || (left_is_date = checkAndGetDataType<DataTypeDate>(arguments[0].get()) || checkAndGetDataType<DataTypeMyDate>(arguments[0].get())) | ||
| || (left_is_date_time = checkAndGetDataType<DataTypeDateTime>(arguments[0].get()) || checkAndGetDataType<DataTypeMyDateTime>(arguments[0].get())) |
There was a problem hiding this comment.
Clickhouse can not compare date and datetime since the internal representation is different, but since MyDate and MyDateTime use the same internal representation, we should allow compare them directly.
There was a problem hiding this comment.
MyDate and MyDateTime can be comparable without any change 😃
| @@ -1269,6 +1306,8 @@ using FunctionToFloat32 = FunctionConvert<DataTypeFloat32, NameToFloat32, Positi | |||
| using FunctionToFloat64 = FunctionConvert<DataTypeFloat64, NameToFloat64, PositiveMonotonicity>; | |||
| using FunctionToDate = FunctionConvert<DataTypeDate, NameToDate, ToIntMonotonicity<UInt16>>; | |||
| using FunctionToDateTime = FunctionConvert<DataTypeDateTime, NameToDateTime, ToIntMonotonicity<UInt32>>; | |||
| using FunctionToMyDate = FunctionConvert<DataTypeMyDate, NameToDate, ToIntMonotonicity<UInt16>>; | |||
| template <> struct FunctionTo<DataTypeDecimal32> { using Type = FunctionToDecimal<Decimal32>; }; | ||
| template <> struct FunctionTo<DataTypeDecimal64> { using Type = FunctionToDecimal<Decimal64>; }; | ||
| template <> struct FunctionTo<DataTypeDecimal128> { using Type = FunctionToDecimal<Decimal128>; }; | ||
| template <> struct FunctionTo<DataTypeDecimal256> { using Type = FunctionToDecimal<Decimal256>; }; |
|
./run-integration-tests |
|
/rebuild |
|
./run-integration-tests |
1 similar comment
|
./run-integration-tests |
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.