Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. fix encode null error, 2. fix empty field type generated by TiFlash #182

Merged
merged 17 commits into from
Aug 16, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
windtalker committed Aug 16, 2019
commit b4a217f9e6bd3197d7b278a856e7acf27ac021d0
9 changes: 6 additions & 3 deletions dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp
Original file line number Diff line number Diff line change
@@ -112,10 +112,13 @@ bool isUInt8Type(const DataTypePtr & type)
{
return true;
}
auto * nullable = typeid_cast<const DataTypeNullable *>(type.get());
if (nullable)
if (type->isNullable())
{
return isUInt8Type(nullable->getNestedType());
auto * nullable = typeid_cast<const DataTypeNullable *>(type.get());
if (typeid_cast<const DataTypeUInt8 *>(nullable->getNestedType().get()))
{
return true;
}
}
return false;
}