FLASH-612: Remove costly logging in dag (#308)

* replace function `gethostbyname` with poco api * Remove costly logging in dag expr analyzer
pingcap · Nov 2, 2019 · 9425bb6 · 9425bb6
1 parent 712069b
commit 9425bb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp b/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp
@@ -48,11 +48,7 @@ static String genFuncString(const String & func_name, const Names & argument_nam
 }
 
 DAGExpressionAnalyzer::DAGExpressionAnalyzer(std::vector<NameAndTypePair> && source_columns_, const Context & context_)
-    : source_columns(std::move(source_columns_)),
-      context(context_),
-      after_agg(false),
-      implicit_cast_count(0),
-      log(&Logger::get("DAGExpressionAnalyzer"))
+    : source_columns(std::move(source_columns_)), context(context_), after_agg(false), implicit_cast_count(0)
 {
     settings = context.getSettings();
 }
@@ -391,8 +387,6 @@ String DAGExpressionAnalyzer::appendCastIfNeeded(const tipb::Expr & expr, Expres
         // todo ignore nullable info??
         if (expected_type->getName() != actual_type->getName())
         {
-            LOG_DEBUG(
-                log, __PRETTY_FUNCTION__ << " Add implicit cast: from " << actual_type->getName() << " to " << expected_type->getName());
             implicit_cast_count++;
             // need to add cast function
             // first construct the second argument

diff --git a/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h b/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h
@@ -34,7 +34,6 @@ class DAGExpressionAnalyzer : private boost::noncopyable
     const Context & context;
     bool after_agg;
     Int32 implicit_cast_count;
-    Poco::Logger * log;
 
 public:
     DAGExpressionAnalyzer(std::vector<NameAndTypePair> && source_columns_, const Context & context_);