OWNERS: sync master to release-7.5 - #69499
ti-chi-bot wants to merge 0 commit into
Conversation
ti-chi-bot
added
approved
cherry-pick-approved
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
do-not-merge/release-note-label-needed
📝 WalkthroughWalkthroughThe PR updates repository ownership configuration to use filter-based routing in several OWNERS files, expands shared alias mappings, and changes approver assignments across multiple package directories. ChangesOwnership routing updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@br/OWNERS`:
- Around line 4-5: The OWNERS update accidentally drops the file-specific
approval rule for br/tidb-lightning.toml, so edits there will no longer require
sig-critical-approvers-tidb-lightning. Update the OWNERS entry to keep the path
filter or equivalent rule for br/tidb-lightning.toml alongside the existing
approvers configuration, using the relevant OWNERS stanza so Lightning changes
still route to the correct approver group.
In `@pkg/executor/OWNERS`:
- Around line 4-7: Add self-ownership for pkg/executor/OWNERS by making sure the
OWNERS file itself matches an ownership rule: either include OWNERS in the
existing filter pattern in the OWNERS config, or add a top-level approvers entry
so edits to this file have an approver. Update the ownership rules in this
OWNERS file so the current analyze.*\.go$ rule does not leave
pkg/executor/OWNERS unmatched when no_parent_owners is true.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 630193a0-e130-482e-8aad-57c6d78d6510
📒 Files selected for processing (26)
OWNERSOWNERS_ALIASESbr/OWNERSlightning/OWNERSlightning/cmd/tidb-lightning-ctl/OWNERSlightning/cmd/tidb-lightning/OWNERSpkg/dumpformat/OWNERSpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| approvers: | ||
| - sig-approvers-br |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Matching files:"
fd '^tidb-lightning\.toml$' .
echo
echo "br/OWNERS"
cat -n br/OWNERS
echo
echo "lightning/OWNERS"
cat -n lightning/OWNERSRepository: pingcap/tidb
Length of output: 680
Keep the Lightning approver rule for br/tidb-lightning.toml
br/tidb-lightning.toml still exists, so removing the path filter routes edits there only to sig-approvers-br instead of sig-critical-approvers-tidb-lightning. Keep the file-specific rule here, or move/remove the file if Lightning review is no longer needed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@br/OWNERS` around lines 4 - 5, The OWNERS update accidentally drops the
file-specific approval rule for br/tidb-lightning.toml, so edits there will no
longer require sig-critical-approvers-tidb-lightning. Update the OWNERS entry to
keep the path filter or equivalent rule for br/tidb-lightning.toml alongside the
existing approvers configuration, using the relevant OWNERS stanza so Lightning
changes still route to the correct approver group.
| filters: | ||
| "analyze.*\\.go$": | ||
| approvers: | ||
| - sig-approvers-stats |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== pkg/executor/OWNERS =="
sed -n '1,40p' pkg/executor/OWNERS
echo
echo "== top-level files directly under pkg/executor =="
fd -t f -d 1 . pkg/executor | sed 's#^\./##' | sortRepository: pingcap/tidb
Length of output: 5478
Add self-ownership for pkg/executor/OWNERS.
With no_parent_owners: true and only the analyze.*\.go$ filter, this file matches no ownership rule, so edits to pkg/executor/OWNERS have no approvers. Add OWNERS to the filter or define a top-level approvers entry.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/executor/OWNERS` around lines 4 - 7, Add self-ownership for
pkg/executor/OWNERS by making sure the OWNERS file itself matches an ownership
rule: either include OWNERS in the existing filter pattern in the OWNERS config,
or add a top-level approvers entry so edits to this file have an approver.
Update the ownership rules in this OWNERS file so the current analyze.*\.go$
rule does not leave pkg/executor/OWNERS unmatched when no_parent_owners is true.
74cccfe to
416a6fb
Compare
ti-chi-bot
Bot
added
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 participant
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-7.5.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit