OWNERS: sync master to release-8.1 - #69081
ti-chi-bot wants to merge 0 commit into
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughRoot Kubernetes OWNERS governance is restructured with filter-based rules, OWNERS_ALIASES are expanded to include community-derived approver teams, and ownership configuration is added or updated across 20 package directories to assign sig-group approvers and enforce approval policies through fine-grained rules. ChangesTiDB Kubernetes OWNERS governance restructuring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@OWNERS`:
- Around line 4-11: The root OWNERS filters make go\.mod$ and .* both match so
go.mod still gets the broad approvals; update the filters so patterns are
mutually exclusive by either narrowing the catch-all (replace .* with a more
specific pattern that excludes go\.mod$), moving the catch-all rule to a
different OWNERS file so it doesn't apply at repo root, or change the go\.mod$
entry to a higher-precedence mechanism (e.g., a dedicated OWNERS for go.mod) so
only the go\.mod$ filter grants sig-critical-approvers-dep and .* no longer adds
sig-community-approvers/sig-community-reviewers to go.mod.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1bcc02e1-3694-4998-bbb7-be619c27b252
📒 Files selected for processing (21)
OWNERSOWNERS_ALIASESpkg/dumpformat/OWNERSpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| go\.mod$: | ||
| approvers: | ||
| - sig-critical-approvers-dep | ||
| .*: | ||
| approvers: | ||
| - sig-community-approvers | ||
| reviewers: | ||
| - sig-community-reviewers |
There was a problem hiding this comment.
go.mod is still effectively approved by the catch-all .* rule
In the root OWNERS filters, go.mod matches both go\.mod$ (adds sig-critical-approvers-dep) and the catch-all .* (adds sig-community-approvers / sig-community-reviewers). repoowners applies all matching filters additively, so the go\.mod$ entry doesn’t narrow approvals for dependency changes. Make the patterns mutually exclusive (or move the broad .* rule elsewhere). (kubernetes.dev)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@OWNERS` around lines 4 - 11, The root OWNERS filters make go\.mod$ and .*
both match so go.mod still gets the broad approvals; update the filters so
patterns are mutually exclusive by either narrowing the catch-all (replace .*
with a more specific pattern that excludes go\.mod$), moving the catch-all rule
to a different OWNERS file so it doesn't apply at repo root, or change the
go\.mod$ entry to a higher-precedence mechanism (e.g., a dedicated OWNERS for
go.mod) so only the go\.mod$ filter grants sig-critical-approvers-dep and .* no
longer adds sig-community-approvers/sig-community-reviewers to go.mod.
d6ac916 to
986af29
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-8.1.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit