Skip to content

OWNERS: sync master to release-8.1 - #69081

Closed
ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1
Closed

ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 10, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-8.1.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

  • Chores
    • Restructured code ownership and approval configurations across the repository to improve governance clarity.
    • Implemented filters-based ownership rules for granular approval control.
    • Updated and consolidated approval group assignments for multiple code modules and components.

@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Root Kubernetes OWNERS governance is restructured with filter-based rules, OWNERS_ALIASES are expanded to include community-derived approver teams, and ownership configuration is added or updated across 20 package directories to assign sig-group approvers and enforce approval policies through fine-grained rules.

Changes

TiDB Kubernetes OWNERS governance restructuring

Layer / File(s) Summary
Root governance framework: OWNERS and OWNERS_ALIASES
OWNERS, OWNERS_ALIASES
Root OWNERS transitions from global lists to filter-based rules: go.mod uses sig-critical-approvers-dep, all other paths use sig-community-approvers and sig-community-reviewers. OWNERS_ALIASES header updates reference synced community membership and the aliases map expands to include sig-community-reviewers/sig-community-approvers plus additional sig-critical-approvers-* entries and updated member lists.
Executor ecosystem ownership: parent and subdirectories
pkg/executor/OWNERS, pkg/executor/aggfuncs/OWNERS, pkg/executor/aggregate/OWNERS, pkg/executor/join/OWNERS, pkg/executor/mppcoordmanager/OWNERS, pkg/executor/sortexec/OWNERS, pkg/executor/test/analyzetest/OWNERS, pkg/executor/unionexec/OWNERS
Executor approval governance is configured across parent directory (with analyze.*.go filter for sig-approvers-stats) and seven subdirectories, each with no_parent_owners: true and sig-approvers-executor as approver.
Approver reassignments for existing packages
pkg/dumpformat/OWNERS, pkg/dxf/OWNERS, pkg/session/OWNERS, pkg/statistics/OWNERS
Four existing packages receive updated approver assignments: pkg/dumpformat replaces sig-approvers-disttask with sig-approvers-dumpling; pkg/dxf replaces sig-approvers-tidb-binlog with sig-approvers-dxf; pkg/session updates filter rules for upgrade_def.go and bootstrap.go/upgrade_run.go; pkg/statistics adds sig-approvers-stats and component/statistics label.
New ownership configurations for standalone packages
pkg/ingestor/OWNERS, pkg/lightning/config/OWNERS, pkg/meta/metadef/OWNERS, pkg/metrics/OWNERS, pkg/sessionctx/vardef/OWNERS, pkg/util/naming/OWNERS
Six new packages receive ownership configurations with appropriate approver groups and no_parent_owners rules: pkg/ingestor (ddl), pkg/lightning/config (critical-tidb-lightning), pkg/meta/metadef (critical-tidb-server + meta), pkg/metrics (metrics), pkg/sessionctx/vardef (critical-tidb-server), and pkg/util/naming (ddl).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • pingcap/tidb#67717: Both PRs update root OWNERS governance to incorporate sig-community-* membership through filter-based rules and community-derived team lists.
  • pingcap/tidb#68706: Both PRs update Kubernetes OWNERS governance data and OWNERS_ALIASES to sync sig-community-* membership composition across ownership configuration.
  • pingcap/tidb#68891: Both PRs modify OWNERS_ALIASES and approver mappings for pkg/dumpformat/OWNERS and pkg/dxf/OWNERS with overlapping changes to sig group assignments.

Suggested labels

size/L, release-note-none, approved

Suggested reviewers

  • windtalker
  • wshwsh12
  • GMHDBJD

Poem

🐰 The governance grows with careful care,
Filters bloom where approvers declare,
Community voices now clearly seen,
Each package knows who should convene,
SIG by SIG, the ownership's keen! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required sections from the template: Issue Number, Problem Summary detail, What changed/how details, and Test/Side effects/Documentation checkboxes. Complete the template sections with Issue Number, detailed problem summary, explicit explanation of changes, and select appropriate checklist items (mark 'No need to test' with justification if applicable).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'OWNERS: sync master to release-8.1' is clear and accurately summarizes the main change—syncing ownership configuration files across branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-8.1

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@OWNERS`:
- Around line 4-11: The root OWNERS filters make go\.mod$ and .* both match so
go.mod still gets the broad approvals; update the filters so patterns are
mutually exclusive by either narrowing the catch-all (replace .* with a more
specific pattern that excludes go\.mod$), moving the catch-all rule to a
different OWNERS file so it doesn't apply at repo root, or change the go\.mod$
entry to a higher-precedence mechanism (e.g., a dedicated OWNERS for go.mod) so
only the go\.mod$ filter grants sig-critical-approvers-dep and .* no longer adds
sig-community-approvers/sig-community-reviewers to go.mod.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1bcc02e1-3694-4998-bbb7-be619c27b252

📥 Commits

Reviewing files that changed from the base of the PR and between 986af29 and d6ac916.

📒 Files selected for processing (21)
  • OWNERS
  • OWNERS_ALIASES
  • pkg/dumpformat/OWNERS
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

Comment thread OWNERS Outdated
Comment on lines +4 to +11
go\.mod$:
approvers:
- sig-critical-approvers-dep
.*:
approvers:
- sig-community-approvers
reviewers:
- sig-community-reviewers

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

go.mod is still effectively approved by the catch-all .* rule

In the root OWNERS filters, go.mod matches both go\.mod$ (adds sig-critical-approvers-dep) and the catch-all .* (adds sig-community-approvers / sig-community-reviewers). repoowners applies all matching filters additively, so the go\.mod$ entry doesn’t narrow approvals for dependency changes. Make the patterns mutually exclusive (or move the broad .* rule elsewhere). (kubernetes.dev)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@OWNERS` around lines 4 - 11, The root OWNERS filters make go\.mod$ and .*
both match so go.mod still gets the broad approvals; update the filters so
patterns are mutually exclusive by either narrowing the catch-all (replace .*
with a more specific pattern that excludes go\.mod$), moving the catch-all rule
to a different OWNERS file so it doesn't apply at repo root, or change the
go\.mod$ entry to a higher-precedence mechanism (e.g., a dedicated OWNERS for
go.mod) so only the go\.mod$ filter grants sig-critical-approvers-dep and .* no
longer adds sig-community-approvers/sig-community-reviewers to go.mod.

@ti-chi-bot ti-chi-bot closed this Jun 27, 2026
@ti-chi-bot
ti-chi-bot force-pushed the bot/sync-owners-to-release-8.1 branch from d6ac916 to 986af29 Compare June 27, 2026 12:43
@ti-chi-bot

ti-chi-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant