Skip to content

OWNERS: sync master to release-7.5 - #69080

Closed
ti-chi-bot wants to merge 0 commit into
release-7.5from
bot/sync-owners-to-release-7.5
Closed

ti-chi-bot wants to merge 0 commit into
release-7.5from
bot/sync-owners-to-release-7.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 10, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-7.5.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

  • Chores
    • Updated code review governance configuration to streamline the approval process across multiple components by implementing pattern-based routing rules.
    • Expanded and reorganized approver team assignments for various project areas to better distribute review responsibilities.

@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c243be07-0310-4a5a-ac82-7de3b6262c68

📥 Commits

Reviewing files that changed from the base of the PR and between 416a6fb and 2acc320.

📒 Files selected for processing (26)
  • OWNERS
  • OWNERS_ALIASES
  • br/OWNERS
  • lightning/OWNERS
  • lightning/cmd/tidb-lightning-ctl/OWNERS
  • lightning/cmd/tidb-lightning/OWNERS
  • pkg/dumpformat/OWNERS
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

📝 Walkthrough

Walkthrough

Root OWNERS file restructured from static approver lists to pattern-based filters delegating go.mod changes to sig-critical-approvers-dep and other paths to sig-community-approvers/reviewers. OWNERS_ALIASES expanded with new approver groups and community aliases. Multiple subdirectory OWNERS files added with pattern-based or direct approver assignments, all disabling parent owner inheritance.

Changes

OWNERS Configuration Restructure and Expansion

Layer / File(s) Summary
Root ownership model restructure and community aliases
OWNERS, OWNERS_ALIASES
Root OWNERS replaced explicit lists with pattern-based filters routing go.mod to sig-critical-approvers-dep and all other paths to sig-community-approvers/sig-community-reviewers. OWNERS_ALIASES expanded with new sig-approvers-* keys and added large community reviewer/approver membership lists.
Executor family OWNERS configuration
pkg/executor/OWNERS, pkg/executor/aggfuncs/OWNERS, pkg/executor/aggregate/OWNERS, pkg/executor/join/OWNERS, pkg/executor/mppcoordmanager/OWNERS, pkg/executor/sortexec/OWNERS, pkg/executor/test/analyzetest/OWNERS, pkg/executor/unionexec/OWNERS
Multiple OWNERS files under pkg/executor and subdirectories disable parent inheritance and route to sig-approvers-executor or sig-approvers-stats for analyze-related files.
Critical infrastructure OWNERS files
lightning/OWNERS, pkg/lightning/config/OWNERS, br/OWNERS, pkg/objstore/OWNERS
Added or modified OWNERS for lightning (with pattern-based tidb-lightning.toml routing), br, and objstore with static approver lists; all disable parent inheritance.
Component-specific approver reassignments
pkg/dumpformat/OWNERS, pkg/dxf/OWNERS, pkg/metrics/OWNERS, pkg/statistics/OWNERS
Individual packages reassigned to different approver groups: dumpformat to sig-approvers-dumpling, dxf to sig-approvers-dxf, statistics to sig-approvers-stats, and metrics under sig-approvers-metrics.
Session and context OWNERS with pattern-based routing
pkg/session/OWNERS, pkg/sessionctx/vardef/OWNERS
pkg/session/OWNERS updated with pattern filtering routing OWNERS and upgrade_def.go to sig-critical-approvers-tidb-server and bootstrap.go/upgrade_run.go to sig-approvers-ddl. pkg/sessionctx/vardef/OWNERS added with filtering for sysvar/tidb_vars files to sig-critical-approvers-tidb-server.
Miscellaneous package OWNERS files
pkg/ingestor/OWNERS, pkg/meta/metadef/OWNERS, pkg/util/naming/OWNERS
Added OWNERS for ingestor (sig-approvers-ddl), meta/metadef (pattern-based with sig-critical-approvers-tidb-server for critical files and sig-approvers-meta default), and util/naming (sig-approvers-ddl), all disabling parent inheritance.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • pingcap/tidb#67717: Both PRs modify the top-level OWNERS file and update the OWNERS documentation URL reference.
  • pingcap/tidb#68891: Both PRs modify OWNERS metadata for pkg/dumpformat/OWNERS and pkg/dxf/OWNERS to route approvals to sig-approvers-dumpling and sig-approvers-dxf.
  • pingcap/tidb#69076: Both PRs modify OWNERS_ALIASES, specifically the sig-community-reviewers membership entries.

Suggested labels

size/L, release-note-none, approved

Suggested reviewers

  • windtalker
  • wshwsh12
  • GMHDBJD

Poem

🐰 Hops through OWNERS files with glee,
Pattern filters now set approvers free,
Community aliases bloom and grow,
Ownership routes get to know,
Where each sig will review with care! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description addresses the key question (what problem does it solve) and explains the change (syncing OWNERS files from master to release-7.5). However, it lacks required sections from the template such as Issue Number, Problem Summary in detail, and the full checklist structure. While the description is adequate for an auto-generated PR, consider including explicit Issue Number reference and completing the checklist sections per the repository template for consistency.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: synchronizing OWNERS files from master to release-7.5 branch, which aligns perfectly with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-7.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot closed this Jun 27, 2026
@ti-chi-bot
ti-chi-bot force-pushed the bot/sync-owners-to-release-7.5 branch from 2acc320 to 416a6fb Compare June 27, 2026 12:43
@ti-chi-bot

ti-chi-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant