Skip to content

OWNERS: sync master to release-8.1 - #69078

Closed
ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1
Closed

ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 10, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-8.1.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated code review governance and approval configurations across the project to improve team coordination and review processes.

@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 78761c45-e3a3-4e28-a669-94a890499a7a

📥 Commits

Reviewing files that changed from the base of the PR and between 986af29 and 83bd49f.

📒 Files selected for processing (21)
  • OWNERS
  • OWNERS_ALIASES
  • pkg/dumpformat/OWNERS
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

📝 Walkthrough

Walkthrough

This PR restructures TiDB's OWNERS governance by migrating the root OWNERS file from static approver/reviewer lists to a rules-based filter configuration, comprehensively updating OWNERS_ALIASES with revised SIG and community memberships, and establishing isolated ownership configurations across 20 package directories with targeted approver group assignments.

Changes

Root governance restructuring and package ownership setup

Layer / File(s) Summary
Root OWNERS filter migration and alias membership update
OWNERS, OWNERS_ALIASES
OWNERS configuration restructured from explicit approver/reviewer username lists to filters-based rules with path-specific assignments (sig-critical-approvers-dep for go.mod, default for .*). OWNERS_ALIASES updated with revised SIG group memberships, removal of obsolete alias keys, and significantly expanded community-reviewer and community-approver member lists.
Executor parent and aggregation ownership
pkg/executor/OWNERS, pkg/executor/aggfuncs/OWNERS, pkg/executor/aggregate/OWNERS, pkg/executor/mppcoordmanager/OWNERS
Parent executor OWNERS enables no-parent-owners with pattern filter for analyze-related Go files assigned to sig-approvers-stats. Aggregation, aggregate, and coordination manager subdirectories assign sig-approvers-executor as sole approver.
Executor operation ownership (join, sort, union)
pkg/executor/join/OWNERS, pkg/executor/sortexec/OWNERS, pkg/executor/unionexec/OWNERS
Join, sort, and union executor subdirectories configured with no-parent-owners and sig-approvers-executor approvals.
Analysis and statistics ownership
pkg/executor/test/analyzetest/OWNERS, pkg/statistics/OWNERS
Executor test analysis directory and statistics package assigned to sig-approvers-stats for analysis/statistics code ownership, with statistics also adding component/statistics label.
DDL domain ownership (ingestor, naming)
pkg/ingestor/OWNERS, pkg/util/naming/OWNERS
Ingestor and util/naming packages configured with sig-approvers-ddl as sole approver and no-parent-owners enabled.
Core infrastructure ownership
pkg/metrics/OWNERS, pkg/lightning/config/OWNERS, pkg/meta/metadef/OWNERS, pkg/session/OWNERS, pkg/sessionctx/vardef/OWNERS
Core service packages configured with domain-specific approvers: metrics with sig-approvers-metrics, lightning with sig-critical-approvers-tidb-lightning, meta with pattern-based assignment of critical and meta approvers, and session/sessionctx with split filters for critical and DDL approvers.
Component ownership shifts
pkg/dumpformat/OWNERS, pkg/dxf/OWNERS
Package ownership transitions from legacy groups: dumpformat moves from sig-approvers-disttask to sig-approvers-dumpling, and dxf moves from sig-approvers-tidb-binlog to sig-approvers-dxf.

🎯 3 (Moderate) | ⏱️ ~25 minutes


Possibly related PRs

  • pingcap/tidb#69075: Both PRs edit OWNERS_ALIASES specifically the sig-community-reviewers and sig-community-approvers membership lists.
  • pingcap/tidb#68891: Both PRs update pkg/dumpformat/OWNERS and pkg/dxf/OWNERS to switch approver group assignments and touch OWNERS_ALIASES ownership mappings.
  • pingcap/tidb#67717: Both PRs update the repository's OWNERS governance data and community-membership sync changes in OWNERS/OWNERS_ALIASES.

Suggested labels

size/L, release-note-none, approved


Suggested reviewers

  • windtalker
  • wshwsh12
  • GMHDBJD

🐰 The OWNERS dance takes shape so grand,
With filters now guiding each approving hand,
Aliases bloom in community care,
Package by package, ownership laid bare!
From disttask to dumpling, the groups now align,
TiDB's governance shines! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required template sections including Issue Number, Problem Summary, What changed and how, and full Check List completion. Add Issue Number with close/ref link, expand Problem Summary, include 'What changed and how it works' section, and complete all checklist items with appropriate selections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'OWNERS: sync master to release-8.1' clearly describes the main change - syncing OWNERS files between branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-8.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot closed this Jun 10, 2026
@ti-chi-bot
ti-chi-bot force-pushed the bot/sync-owners-to-release-8.1 branch from 83bd49f to 986af29 Compare June 10, 2026 04:03
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant