OWNERS: sync master to release-8.1 - #68872
ti-chi-bot wants to merge 0 commit into
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThe PR restructures TiDB's repository ownership governance from hardcoded username lists to a centralized filter-based ruleset with distributed SIG-specific approval assignments. The root OWNERS file now routes approvals via filters (go.mod dependencies and catch-all), OWNERS_ALIASES defines all SIG and community approver/reviewer groups, and 15 new subdirectory OWNERS files enforce localized approval policies. ChangesRepository Ownership and Approval Governance Restructuring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/executor/OWNERS`:
- Around line 2-7: Add a catch-all approver rule because no_parent_owners: true
plus the existing filter "analyze.*\\.go$" leaves other files without approvers;
update the OWNERS config by adding a new filters entry (e.g., pattern ".*" or a
more specific fallback) that lists the appropriate approvers (for example the
same group used for analyze files or a repo-wide approvers group) so files not
matched by "analyze.*\\.go$" have an approval path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b4682c0f-e927-4c59-9eb9-ebd21fb47798
📒 Files selected for processing (20)
OWNERSOWNERS_ALIASESpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| options: | ||
| no_parent_owners: true | ||
| filters: | ||
| "analyze.*\\.go$": | ||
| approvers: | ||
| - sig-approvers-stats |
There was a problem hiding this comment.
Add a catch-all approver rule for non-analyze files.
With no_parent_owners: true on Line 3, the current config only assigns approvers to analyze.*.go. Other files directly under pkg/executor will be left without any approver path.
Suggested fix
options:
no_parent_owners: true
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats
+ ".*":
+ approvers:
+ - sig-approvers-executor📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| options: | |
| no_parent_owners: true | |
| filters: | |
| "analyze.*\\.go$": | |
| approvers: | |
| - sig-approvers-stats | |
| options: | |
| no_parent_owners: true | |
| filters: | |
| "analyze.*\\.go$": | |
| approvers: | |
| - sig-approvers-stats | |
| ".*": | |
| approvers: | |
| - sig-approvers-executor |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/executor/OWNERS` around lines 2 - 7, Add a catch-all approver rule
because no_parent_owners: true plus the existing filter "analyze.*\\.go$" leaves
other files without approvers; update the OWNERS config by adding a new filters
entry (e.g., pattern ".*" or a more specific fallback) that lists the
appropriate approvers (for example the same group used for analyze files or a
repo-wide approvers group) so files not matched by "analyze.*\\.go$" have an
approval path.
79c37ac to
986af29
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-8.1.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit