Skip to content

OWNERS: sync master to release-8.1 - #68872

Closed
ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1
Closed

ti-chi-bot wants to merge 0 commit into
release-8.1from
bot/sync-owners-to-release-8.1

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 2, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-8.1.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

  • Chores
    • Updated code review and approval governance configurations across the repository. Restructured root approval rules into filter-based rulesets and expanded approval group membership. Added granular ownership definitions for multiple package modules to streamline the review process.

@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved labels Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR restructures TiDB's repository ownership governance from hardcoded username lists to a centralized filter-based ruleset with distributed SIG-specific approval assignments. The root OWNERS file now routes approvals via filters (go.mod dependencies and catch-all), OWNERS_ALIASES defines all SIG and community approver/reviewer groups, and 15 new subdirectory OWNERS files enforce localized approval policies.

Changes

Repository Ownership and Approval Governance Restructuring

Layer / File(s) Summary
Root governance and approval alias definitions
OWNERS, OWNERS_ALIASES
Root OWNERS file converted to filters-based routing: go.mod$ changes require sig-critical-approvers-dep, all other paths use sig-community-approvers and sig-community-reviewers. OWNERS_ALIASES expanded with updated SIG alias memberships and two new top-level sig-community-reviewers and sig-community-approvers groups.
Executor subsystem ownership configuration
pkg/executor/OWNERS, pkg/executor/aggfuncs/OWNERS, pkg/executor/aggregate/OWNERS, pkg/executor/join/OWNERS, pkg/executor/mppcoordmanager/OWNERS, pkg/executor/sortexec/OWNERS, pkg/executor/test/analyzetest/OWNERS, pkg/executor/unionexec/OWNERS
Eight OWNERS files added or updated in executor subsystem directories with no_parent_owners: true. Files route to sig-approvers-executor by default; analyze test files additionally specify sig-approvers-stats. The aggfuncs approver switches from sig-approvers-tidb-binlog to sig-approvers-executor.
Subsystem-specific ownership configurations
pkg/ingestor/OWNERS, pkg/lightning/config/OWNERS, pkg/meta/metadef/OWNERS, pkg/metrics/OWNERS, pkg/session/OWNERS, pkg/sessionctx/vardef/OWNERS, pkg/statistics/OWNERS, pkg/util/naming/OWNERS
Eight OWNERS files for distributed subsystems each disable parent owner inheritance and assign subsystem-specific approvers: ddl (ingestor, util/naming), lightning-critical (lightning/config), meta (meta/metadef), metrics, session/sessionctx variants, and stats (statistics). Session file reassigns bootstrap.go approval from server-critical to ddl, and extends ddl coverage to upgrade_run.go. Statistics approver changes from sig-approvers-planner to sig-approvers-stats.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • pingcap/tidb#68706: Updates OWNERS/OWNERS_ALIASES around sig-community-* approver/reviewer membership and configuration.
  • pingcap/tidb#67717: Also restructures OWNERS/OWNERS_ALIASES to define sig-community-approvers/reviewers-driven approval rules and community SIG membership synchronization.

Suggested labels

size/L, release-note-none, approved

Suggested reviewers

  • windtalker
  • wshwsh12

Poem

🐰 A rabbit hops through governance's grand hall,
Where approvers once scattered now answer the call—
Filters align, and communities rise,
While SIGs take their rightful place in the skies! ✨
From chaos to order, a tidier reign,
The OWNERS file dances through TiDB's domain.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: syncing OWNERS files from master to release-8.1, which matches the file modifications shown in the raw summary.
Description check ✅ Passed The description explains the problem (syncing OWNERS files) and what changed (auto-generated update of OWNERS and OWNERS_ALIASES). However, it deviates from the template structure by omitting formal sections and using informal slash-commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-8.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/executor/OWNERS`:
- Around line 2-7: Add a catch-all approver rule because no_parent_owners: true
plus the existing filter "analyze.*\\.go$" leaves other files without approvers;
update the OWNERS config by adding a new filters entry (e.g., pattern ".*" or a
more specific fallback) that lists the appropriate approvers (for example the
same group used for analyze files or a repo-wide approvers group) so files not
matched by "analyze.*\\.go$" have an approval path.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b4682c0f-e927-4c59-9eb9-ebd21fb47798

📥 Commits

Reviewing files that changed from the base of the PR and between 986af29 and 79c37ac.

📒 Files selected for processing (20)
  • OWNERS
  • OWNERS_ALIASES
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

Comment thread pkg/executor/OWNERS Outdated
Comment on lines +2 to +7
options:
no_parent_owners: true
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add a catch-all approver rule for non-analyze files.

With no_parent_owners: true on Line 3, the current config only assigns approvers to analyze.*.go. Other files directly under pkg/executor will be left without any approver path.

Suggested fix
 options:
   no_parent_owners: true
 filters:
   "analyze.*\\.go$":
     approvers:
       - sig-approvers-stats
+  ".*":
+    approvers:
+      - sig-approvers-executor
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
options:
no_parent_owners: true
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats
options:
no_parent_owners: true
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats
".*":
approvers:
- sig-approvers-executor
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/executor/OWNERS` around lines 2 - 7, Add a catch-all approver rule
because no_parent_owners: true plus the existing filter "analyze.*\\.go$" leaves
other files without approvers; update the OWNERS config by adding a new filters
entry (e.g., pattern ".*" or a more specific fallback) that lists the
appropriate approvers (for example the same group used for analyze files or a
repo-wide approvers group) so files not matched by "analyze.*\\.go$" have an
approval path.

@ti-chi-bot ti-chi-bot closed this Jun 3, 2026
@ti-chi-bot
ti-chi-bot force-pushed the bot/sync-owners-to-release-8.1 branch from 79c37ac to 986af29 Compare June 3, 2026 06:34
@ti-chi-bot

ti-chi-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant