OWNERS: sync master to release-7.5 - #68871
ti-chi-bot wants to merge 0 commit into
Conversation
ti-chi-bot
added
approved
cherry-pick-approved
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
do-not-merge/release-note-label-needed
📝 WalkthroughWalkthroughThe PR restructures TiDB's code ownership model from hardcoded GitHub username lists to a filter-based group system. Root OWNERS transitions to patterns for dependency and community approvals; OWNERS_ALIASES expands with new approver/reviewer team groups. Package-level OWNERS files are introduced across 24 directories to apply specific approver assignments within executor, backup, lighting, core, and server configuration subsystems. OWNERS Restructure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@OWNERS_ALIASES`:
- Line 319: Replace the lowercase entry `yangkeao` with the canonical casing
`YangKeao` in the OWNERS_ALIASES group so it matches other alias groups (e.g.,
sig-approvers-domain, sig-approvers-ddl, sig-approvers-infoschema,
sig-approvers-meta, sig-approvers-owner, sig-approvers-table); update the
single-line alias entry to `YangKeao` to ensure consistent username matching
across all alias lists.
- Line 218: Username casing inconsistency: standardize the alias entry so the
username matches other groups. Replace the uppercase alias "GMHDBJD" with the
lowercase form "gmhdbjd" in the OWNERS_ALIASES entry to ensure consistency with
other groups (e.g., sig-approvers-lightning, sig-approvers-disttask,
sig-approvers-dumpling); update any other occurrences in the same file to the
lowercase form if present, then run the repo's OWNERs validation/lint to confirm
approvals will match.
In `@pkg/executor/OWNERS`:
- Around line 2-7: The OWNERS file sets no_parent_owners: true and only defines
a filter for "analyze.*\\.go$" so other files in pkg/executor/ have no approver;
add a default approver entry (either a top-level approvers: list or a catch-all
filters entry such as ".*" with approvers) so non-analyze files have an explicit
approver group; update the same OWNERS file ensuring you keep no_parent_owners:
true and the existing "analyze.*\\.go$" filter while adding the new default
approvers list (refer to the no_parent_owners, filters, and the
"analyze.*\\.go$" pattern to locate where to add it).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ab534ca7-0896-4a1c-99d5-7b897b5f07f8
📒 Files selected for processing (25)
OWNERSOWNERS_ALIASESbr/OWNERSlightning/OWNERSlightning/cmd/tidb-lightning-ctl/OWNERSlightning/cmd/tidb-lightning/OWNERSpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| - Deardrops | ||
| - Defined2014 | ||
| - Ehco1996 | ||
| - GMHDBJD |
There was a problem hiding this comment.
Username casing inconsistency: GMHDBJD vs gmhdbjd.
This user appears as GMHDBJD here but as gmhdbjd in other alias groups (e.g., sig-approvers-lightning, sig-approvers-disttask, sig-approvers-dumpling). If the OWNERS system is case-sensitive, this could prevent approval matching.
Proposed fix
- - GMHDBJD
+ - gmhdbjd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - GMHDBJD | |
| - gmhdbjd |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@OWNERS_ALIASES` at line 218, Username casing inconsistency: standardize the
alias entry so the username matches other groups. Replace the uppercase alias
"GMHDBJD" with the lowercase form "gmhdbjd" in the OWNERS_ALIASES entry to
ensure consistency with other groups (e.g., sig-approvers-lightning,
sig-approvers-disttask, sig-approvers-dumpling); update any other occurrences in
the same file to the lowercase form if present, then run the repo's OWNERs
validation/lint to confirm approvals will match.
| - xhebox | ||
| - xiongjiwei | ||
| - xuyifangreeneyes | ||
| - yangkeao |
There was a problem hiding this comment.
Username casing inconsistency: yangkeao vs YangKeao.
This user appears as yangkeao here but as YangKeao in other alias groups (e.g., sig-approvers-domain, sig-approvers-ddl, sig-approvers-infoschema, sig-approvers-meta, sig-approvers-owner, sig-approvers-table). Recommend using consistent casing to avoid potential matching issues.
Proposed fix
- - yangkeao
+ - YangKeao📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - yangkeao | |
| - YangKeao |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@OWNERS_ALIASES` at line 319, Replace the lowercase entry `yangkeao` with the
canonical casing `YangKeao` in the OWNERS_ALIASES group so it matches other
alias groups (e.g., sig-approvers-domain, sig-approvers-ddl,
sig-approvers-infoschema, sig-approvers-meta, sig-approvers-owner,
sig-approvers-table); update the single-line alias entry to `YangKeao` to ensure
consistent username matching across all alias lists.
| options: | ||
| no_parent_owners: true | ||
| filters: | ||
| "analyze.*\\.go$": | ||
| approvers: | ||
| - sig-approvers-stats |
There was a problem hiding this comment.
Add a default approver group for non-analyze files.
With no_parent_owners: true, this file currently routes only analyze.*.go and leaves other files in pkg/executor/ without an explicit approver path.
Suggested patch
options:
no_parent_owners: true
+approvers:
+ - sig-approvers-executor
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| options: | |
| no_parent_owners: true | |
| filters: | |
| "analyze.*\\.go$": | |
| approvers: | |
| - sig-approvers-stats | |
| options: | |
| no_parent_owners: true | |
| approvers: | |
| - sig-approvers-executor | |
| filters: | |
| "analyze.*\\.go$": | |
| approvers: | |
| - sig-approvers-stats |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/executor/OWNERS` around lines 2 - 7, The OWNERS file sets
no_parent_owners: true and only defines a filter for "analyze.*\\.go$" so other
files in pkg/executor/ have no approver; add a default approver entry (either a
top-level approvers: list or a catch-all filters entry such as ".*" with
approvers) so non-analyze files have an explicit approver group; update the same
OWNERS file ensuring you keep no_parent_owners: true and the existing
"analyze.*\\.go$" filter while adding the new default approvers list (refer to
the no_parent_owners, filters, and the "analyze.*\\.go$" pattern to locate where
to add it).
1ebf6c1 to
416a6fb
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
size/XS
1 participant
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-7.5.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit