Skip to content

*: update DDL-related owners - #67925

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
xhebox:owner
Apr 22, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
xhebox:owner

Conversation

@xhebox

@xhebox xhebox commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

domain/ddl/meta/table/infoschema/owner

What problem does this PR solve?

Issue Number: Close #67926

sig-infra is now in charge of DDL. For better development experience, update the owner list.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Added five new members to multiple approver aliases to reflect updated team membership.
    • Corrected the casing of one existing member in the community approvers list.

domain/ddl/meta/table/infoschema/owner

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
xhebox requested review from bb7133 and wjhuang2016 April 21, 2026 02:32
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 21, 2026
@pantheon-ai

pantheon-ai Bot commented Apr 21, 2026

Copy link
Copy Markdown

@xhebox I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details.

⏳ This process typically takes 10-30 minutes depending on the complexity of the changes.

ℹ️ Learn more details on Pantheon AI.

@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2026
@tiprow

tiprow Bot commented Apr 21, 2026

Copy link
Copy Markdown

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Apr 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7a29295b-f2e4-4f4c-bd24-9ec2afc96d02

📥 Commits

Reviewing files that changed from the base of the PR and between c78754a and 2b1d805.

📒 Files selected for processing (1)
  • OWNERS_ALIASES
🚧 Files skipped from review as they are similar to previous changes (1)
  • OWNERS_ALIASES

📝 Walkthrough

Walkthrough

Updated OWNERS_ALIASES to add five usernames (bb7133, djshow832, xhebox, tiancaiamao, YangKeao) to six sig-approvers aliases and adjusted the casing of yangkeaoYangKeao in sig-community-approvers. No removals besides the casing change.

Changes

Cohort / File(s) Summary
OWNERS_ALIASES update
OWNERS_ALIASES
Added bb7133, djshow832, xhebox, tiancaiamao, YangKeao to: sig-approvers-domain, sig-approvers-ddl, sig-approvers-infoschema, sig-approvers-meta, sig-approvers-owner, sig-approvers-table. Also changed yangkeaoYangKeao in sig-community-approvers (casing only).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ok-to-test, lgtm

Poem

🐰 New names hop into the list tonight,
Five bright paws added, everything looks right,
Casing polished with a gentle tweak,
Approvers gathered—steady, quick, and sleek. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title '*: update DDL-related owners' accurately describes the main change of updating owner aliases for DDL-related code paths.
Description check ✅ Passed The description follows the template structure with required sections including issue reference (Close #67926), problem statement, test selection, and release notes.
Linked Issues check ✅ Passed The PR fulfills the linked issue #67926 requirement by updating the owner list for DDL-related aliases to reflect sig-infra responsibility.
Out of Scope Changes check ✅ Passed All changes are scoped to OWNERS_ALIASES file updates for DDL-related paths as required; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xhebox

xhebox commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot

ti-chi-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

@expxiaoli: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread OWNERS_ALIASES Outdated
- djshow832
- xhebox
- tiancaiamao
- yangkeao

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether it's case sensitive. My github username is YangKeao.

@xhebox xhebox Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    - yangkeao
    - you06
    - youjiali1995
    - ywqzzy
    - zanmato1984
    - zhangjinpeng87
    - zhaoxinyu
    - zhouqiang-cl
    - zimulala
    - zwj-coder
    - zyguan
    - zz-jason

I believe that it is not. But let me just change it

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 21, 2026
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
xhebox requested a review from YangKeao April 22, 2026 02:11
@ti-chi-bot

ti-chi-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: expxiaoli, wjhuang2016, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-04-21 06:47:21.88863919 +0000 UTC m=+2062047.093999247: ☑️ agreed by wjhuang2016.
  • 2026-04-22 02:16:43.930294598 +0000 UTC m=+2132209.135654655: ☑️ agreed by YangKeao.

@ti-chi-bot
ti-chi-bot Bot merged commit 874ff37 into pingcap:master Apr 22, 2026
10 of 12 checks passed
premal pushed a commit to premal/tidb that referenced this pull request Apr 30, 2026
yongman pushed a commit to yongman/tidb that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

udpate owner list of DDL

4 participants