expression,planner: reuse the PropConstSolver to improve performance#61838
Merged
ti-chi-bot[bot] merged 21 commits intopingcap:masterfrom Jun 20, 2025
Merged
expression,planner: reuse the PropConstSolver to improve performance#61838ti-chi-bot[bot] merged 21 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 21 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Member
Author
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61838 +/- ##
================================================
+ Coverage 73.0426% 73.2299% +0.1872%
================================================
Files 1730 1736 +6
Lines 481654 485490 +3836
================================================
+ Hits 351813 355524 +3711
- Misses 108280 108310 +30
- Partials 21561 21656 +95
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
/retest |
Member
Author
|
/retest |
AilinKid
reviewed
Jun 20, 2025
| s.ctx = ctx | ||
| return s.solve(conditions) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Exported func should have a comment
AilinKid
approved these changes
Jun 20, 2025
Member
Author
|
/retest |
wshwsh12
approved these changes
Jun 20, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
XuHuaiyu
approved these changes
Jun 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #61837
Problem Summary:
What changed and how does it work?
Check List
Tests
before
https://flamegraph.com/share/bead835c-4ce4-11f0-b170-826a90ca3d79
after
https://flamegraph.com/share/29d160f8-4d7b-11f0-8d36-0698304f6f10
flame graph has less object in the PropConstSolver.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.