importinto/lightning: check max row size when parsing csv to avoid OOM (#58592)#59408
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from Feb 12, 2025
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
Member
Author
|
@D3Hunter This PR has conflicts, I have hold it. |
D3Hunter
approved these changes
Feb 12, 2025
tangenta
approved these changes
Feb 12, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59408 +/- ##
================================================
Coverage ? 73.6550%
================================================
Files ? 1097
Lines ? 353479
Branches ? 0
================================================
Hits ? 260355
Misses ? 76390
Partials ? 16734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #58592
What problem does this PR solve?
Issue Number: close #58590
Problem Summary:
What changed and how does it work?
Check List
Tests
import a file with 20 fields, each field is about 10+M, total row size is about 266M
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.