Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Allow Point_Get during DDL with Global Index (#56382) #56849

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56382

What problem does this PR solve?

Issue Number: ref #55819 , ref #45133 , close #56819

Problem Summary:
During DDL that affects Global Index, the PointGet access method is blocked, which may cause temporary bad query plans during partitioning management commands, like DROP/TRUNCATE/REORGANIZE PARTITION.

What changed and how does it work?

Allow PointGet, by filter away the partitions that should not be seen (like when the cleanup of the global index is ongoing).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@27e78ae). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56849   +/-   ##
================================================
  Coverage               ?   56.2164%           
================================================
  Files                  ?       1751           
  Lines                  ?     628168           
  Branches               ?          0           
================================================
  Hits                   ?     353134           
  Misses                 ?     251094           
  Partials               ?      23940           
Flag Coverage Δ
integration 36.8127% <62.1621%> (?)
unit 72.4831% <74.7747%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3414% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 25, 2024
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2024
Copy link

ti-chi-bot bot commented Oct 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-25 16:46:43.325158261 +0000 UTC m=+22716.164313830: ☑️ agreed by mjonss.
  • 2024-10-25 17:44:21.268834869 +0000 UTC m=+26174.107990410: ☑️ agreed by bb7133.

@bb7133
Copy link
Member

bb7133 commented Oct 25, 2024

/retest

Copy link

ti-chi-bot bot commented Oct 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, mjonss, tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2511e92 into pingcap:release-8.4 Oct 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants