-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slowlog: print correct Commit_primary_rpc_detail
#56448
Conversation
Signed-off-by: you06 <[email protected]>
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56448 +/- ##
================================================
+ Coverage 73.4714% 75.3656% +1.8942%
================================================
Files 1605 1628 +23
Lines 445003 465240 +20237
================================================
+ Hits 326950 350631 +23681
+ Misses 97992 93714 -4278
- Partials 20061 20895 +834
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #56445
Problem Summary:
What changed and how does it work?
Print the correct
Commit_primary_rpc_detail
, which is different fromSlowest_prewrite_rpc_detail
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.