Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowlog: print correct Commit_primary_rpc_detail #56448

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

you06
Copy link
Contributor

@you06 you06 commented Oct 4, 2024

What problem does this PR solve?

Issue Number: close #56445

Problem Summary:

What changed and how does it work?

Print the correct Commit_primary_rpc_detail, which is different from Slowest_prewrite_rpc_detail.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2024
Copy link

tiprow bot commented Oct 4, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3656%. Comparing base (a0a741e) to head (08fed11).
Report is 93 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56448        +/-   ##
================================================
+ Coverage   73.4714%   75.3656%   +1.8942%     
================================================
  Files          1605       1628        +23     
  Lines        445003     465240     +20237     
================================================
+ Hits         326950     350631     +23681     
+ Misses        97992      93714      -4278     
- Partials      20061      20895       +834     
Flag Coverage Δ
integration 48.9504% <50.0000%> (?)
unit 72.5025% <100.0000%> (-0.0505%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 50.2450% <ø> (+4.2308%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 10:31:59.056301369 +0000 UTC m=+955674.476514381: ☑️ agreed by ekexium.
  • 2024-10-08 10:34:54.32992376 +0000 UTC m=+955849.750136772: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot merged commit 7bf8629 into pingcap:master Oct 8, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit_primary_rpc_detail is same to Slowest_prewrite_rpc_detail in some places
3 participants