-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: disable some json function from pushdown to TiFlash (#56177) #56225
expression: disable some json function from pushdown to TiFlash (#56177) #56225
Conversation
Signed-off-by: xufei <[email protected]>
b8e42ab
to
855a789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56225 +/- ##
================================================
Coverage ? 73.4599%
================================================
Files ? 1211
Lines ? 380568
Branches ? 0
================================================
Hits ? 279565
Misses ? 83151
Partials ? 17852 |
This is an automated cherry-pick of #56177
What problem does this PR solve?
Issue Number: close #56173
Problem Summary:
The root cause is TiFlash does not support json compare, it just use string compare instead. So currently, we need disable pushing down such functions to TiFlash
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.