Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix unique key get wrong row count when to query the NULL value |tidb-test=pr/2400 #56191

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56117

What problem does this PR solve?

Issue Number: close #56116

Problem Summary:

What changed and how does it work?

There will be issues with the row count under index/unique index. Previously, we would uniformly count the row count for this PointGet as 1, but if it is null, it will no longer be 1 and must be calculated according to the null count.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

From internal test cases

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-56117-to-release-7.5 branch from dea6d16 to 9bfc845 Compare September 20, 2024 08:47
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2390 (#56117) planner: fix unique key get wrong row count when to query the NULL value (#56117) Sep 23, 2024
@hawkingrei
Copy link
Member

/test all

Copy link

tiprow bot commented Sep 23, 2024

@hawkingrei: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value (#56117) planner: fix unique key get wrong row count when to query the NULL value |tidb-test=pr/2400 Sep 23, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@ac1493d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #56191   +/-   ##
================================================
  Coverage               ?   72.3655%           
================================================
  Files                  ?       1413           
  Lines                  ?     413879           
  Branches               ?          0           
================================================
  Hits                   ?     299506           
  Misses                 ?      94618           
  Partials               ?      19755           
Flag Coverage Δ
unit 72.3655% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5592% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 03:21:17.67137224 +0000 UTC m=+1449747.411796182: ☑️ agreed by hawkingrei.
  • 2024-09-23 05:57:00.996991324 +0000 UTC m=+1459090.737415263: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit c931d58 into pingcap:release-7.5 Sep 23, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants